Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

use cover module for test coverage #704

Closed
wants to merge 1 commit into from

3 participants

@defunctzombie

cover module does not require instrumentation to use.

make test-cov as before

@defunctzombie defunctzombie use cover module for test coverage
cover module does not require instrumentation to use.

`make test-cov` as before
9551eba
@tj
Owner
tj commented

I still prefer mocha's personally, easier to see which have lower coverage etc

@defunctzombie
@tj
Owner
tj commented

not a huge gain though really haha it's one ternary :p

@tj
Owner
tj commented

and the code pages are ugly :(

@defunctzombie
@defunctzombie
@defunctzombie

I am sure it can be made to look just as pretty :) I have been meaning to get around to making it more api friendly to you can integrate it into other tools. I think the maintainer is a bit busy (as all of us)

@tj
Owner
tj commented

I dont mind the table portion but I also prefer that mocha's always has the menu available, easier to quickly jump between files etc

@defunctzombie
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 7, 2012
  1. @defunctzombie

    use cover module for test coverage

    defunctzombie authored
    cover module does not require instrumentation to use.
    
    `make test-cov` as before
This page is out of date. Refresh to see the latest.
Showing with 6 additions and 11 deletions.
  1. +2 −0  .gitignore
  2. +3 −6 Makefile
  3. +0 −4 index.js
  4. +1 −1  package.json
View
2  .gitignore
@@ -15,3 +15,5 @@ docs/*.html
docs/*.json
node_modules
.idea
+cover_html
+.coverage_data
View
9 Makefile
@@ -15,11 +15,8 @@ test:
docs: $(HTML)
@mv $(HTML) docs
-test-cov: lib-cov
- @CONNECT_COV=1 $(MAKE) test REPORTER=html-cov > coverage.html
-
-lib-cov:
- @jscoverage lib $@
+test-cov:
+ @NODE_ENV=test cover run ./node_modules/mocha/bin/_mocha && cover report html
%.html: %.js
$(DOX) < $< | node support/docs > $@
@@ -37,4 +34,4 @@ site: docclean docs
benchmark:
@./support/bench
-.PHONY: test-cov site docs test docclean benchmark
+.PHONY: test-cov site docs test docclean benchmark
View
4 index.js
@@ -1,4 +0,0 @@
-
-module.exports = process.env.CONNECT_COV
- ? require('./lib-cov/connect')
- : require('./lib/connect');
View
2  package.json
@@ -24,7 +24,7 @@
"jade": "*",
"dox": "*"
},
- "main": "index",
+ "main": "lib/connect",
"engines": {
"node": ">= 0.5.0"
},
Something went wrong with that request. Please try again.