Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

use cover module for test coverage #704

Closed
wants to merge 1 commit into from

3 participants

Roman Shtylman TJ Holowaychuk jongleberry
Roman Shtylman

cover module does not require instrumentation to use.

make test-cov as before

Roman Shtylman defunctzombie use cover module for test coverage
cover module does not require instrumentation to use.

`make test-cov` as before
9551eba
TJ Holowaychuk
Owner
tj commented

I still prefer mocha's personally, easier to see which have lower coverage etc

Roman Shtylman
TJ Holowaychuk
Owner
tj commented

not a huge gain though really haha it's one ternary :p

TJ Holowaychuk
Owner
tj commented

and the code pages are ugly :(

Roman Shtylman
Roman Shtylman
Roman Shtylman

I am sure it can be made to look just as pretty :) I have been meaning to get around to making it more api friendly to you can integrate it into other tools. I think the maintainer is a bit busy (as all of us)

TJ Holowaychuk
Owner
tj commented

I dont mind the table portion but I also prefer that mocha's always has the menu available, easier to quickly jump between files etc

Roman Shtylman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 7, 2012
  1. Roman Shtylman

    use cover module for test coverage

    defunctzombie authored
    cover module does not require instrumentation to use.
    
    `make test-cov` as before
This page is out of date. Refresh to see the latest.
Showing with 6 additions and 11 deletions.
  1. +2 −0  .gitignore
  2. +3 −6 Makefile
  3. +0 −4 index.js
  4. +1 −1  package.json
2  .gitignore
View
@@ -15,3 +15,5 @@ docs/*.html
docs/*.json
node_modules
.idea
+cover_html
+.coverage_data
9 Makefile
View
@@ -15,11 +15,8 @@ test:
docs: $(HTML)
@mv $(HTML) docs
-test-cov: lib-cov
- @CONNECT_COV=1 $(MAKE) test REPORTER=html-cov > coverage.html
-
-lib-cov:
- @jscoverage lib $@
+test-cov:
+ @NODE_ENV=test cover run ./node_modules/mocha/bin/_mocha && cover report html
%.html: %.js
$(DOX) < $< | node support/docs > $@
@@ -37,4 +34,4 @@ site: docclean docs
benchmark:
@./support/bench
-.PHONY: test-cov site docs test docclean benchmark
+.PHONY: test-cov site docs test docclean benchmark
4 index.js
View
@@ -1,4 +0,0 @@
-
-module.exports = process.env.CONNECT_COV
- ? require('./lib-cov/connect')
- : require('./lib/connect');
2  package.json
View
@@ -24,7 +24,7 @@
"jade": "*",
"dox": "*"
},
- "main": "index",
+ "main": "lib/connect",
"engines": {
"node": ">= 0.5.0"
},
Something went wrong with that request. Please try again.