Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix some issues under IE8 #732

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

JacksonTian commented Jan 15, 2013

The Element.all method is available under IE8, and can't be overrided it. el.all causes an error under IE8.

I use el.$$ that inspired by Prototypejs' $$ instead. It means get a list by selector.

filter is only available under ES5, but IE8 isn't.

textContent not be supported by IE8, use innerText instead.

Contributor

JacksonTian commented Jan 20, 2013

TJ, could you review this pull request.

Contributor

jonathanong commented Sep 15, 2013

any reason we should support IE8 in our docs? this is targeted towards devs, not plebians

Contributor

JacksonTian commented Sep 15, 2013

IE8 throws err. Just want it can be used.

Contributor

jonathanong commented Sep 16, 2013

i'm weary to change any styles to the documentation. i think including the source code is silly, and it should just all be moved to github/markdown for simplicity.

Contributor

JacksonTian commented Sep 16, 2013

I agree with you.

Contributor

jonathanong commented Sep 16, 2013

You may want to contribute to visionmedia/expressjs.com. I'm not sure if all of connect's docs are there, but some of the more important ones are. Not sure if 100% of the docs will move there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment