Directory middleware improvements. #734

Closed
wants to merge 12 commits into
from

Conversation

Projects
None yet
5 participants
Contributor

simov commented Jan 22, 2013

{ icons: false, view: 'tiles' } - defaults no need to specify
01-tiles-1-
{ icons: true }
01-tiles-2-
{ view: 'details', sort: { dirFirst: true } }
02-details-1-
{ icons: true, view: 'details', sort: { dirFirst: true } }
02-details-2-
{ view: 'tiles' } - doesn't matter, typed ico in the search field
03-mobile-1
{ icons: true, view: 'details' } - typed ico in the search field
03-mobile-2

Icons from http://openiconlibrary.sourceforge.net/ they have 230 mime type icons and lots of others as well.

Will be adding more stuff into this branch in the future.

Member

tj commented Jan 22, 2013

cool! I'll take a look after work and tweak/merge

STRML commented Mar 28, 2013

This is really great, any chance of a merge into master?

dougwilson was assigned Oct 24, 2013

Contributor

jonathanong commented Dec 2, 2013

Contributor

dougwilson commented Dec 2, 2013

I'm still looking at this. It is a lot of changes and new features all at once in a single pull request, which makes it difficult, especially since #751 is trying to change the style, which make it hard to then take some good new features from this.

Contributor

simov commented Dec 2, 2013

Yeah I can split the things a little bit also I can create a new branch out of the latest master. Also I can refactore it a little bit since 10 months are passed. Of course if there is an interest in this.

Contributor

dougwilson commented Dec 2, 2013

I am interested in this, of particular: the style looking good on mobile, the details view, and whatever bug fixes. I have support for folder icons and sorting folders first, which will be on master is just a bit. From that, the pull requests should be nice and small.

Contributor

simov commented Dec 2, 2013

OK, I'll pull the latest stuff and make the changes, btw the iconStyle function is really important I think because it adds the base64 of each icon+size only once instead of multiple times for each file respectively.

Contributor

dougwilson commented Dec 2, 2013

Ah, I see, that encodes the necessary ones in the CSS as background images. That looks good indeed.

Contributor

dougwilson commented Dec 2, 2013

@simov the master branch is now up-to-date with directory middleware changes. Also if you want your changes to be accepted before the next major connect release, please keep the arguments to exports[key] backwards-compatible (for people using their own formatter).

simov closed this Dec 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment