when session.save error should return error #755

Merged
merged 1 commit into from Mar 26, 2013

Conversation

Projects
None yet
5 participants

No description provided.

Contributor

fengmk2 commented Feb 27, 2013

Yep, we need to handle session.save() error.

Contributor

fengmk2 commented Feb 27, 2013

jifeng commented Feb 27, 2013

+1

tj merged commit 1da7800 into senchalabs:master Mar 26, 2013

1 check failed

default The Travis build failed
Details
Member

tj commented Mar 26, 2013

sorry had to revert this, we can't next() there since it's deferred, a response is already mid-completion

Contributor

fengmk2 commented Mar 26, 2013

We should log the error?

Member

tj commented Mar 26, 2013

yeah that's about all we can do here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment