Fix for issue #762: Session middleware fails to add session when request contains absoluteURI #763

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
3 participants

jwalton commented Mar 13, 2013

No description provided.

jwalton commented Mar 13, 2013

This is a fix for #762.

Contributor

fengmk2 commented Mar 14, 2013

Any test cases to reappear absoluteURI problem?

coolaj86 referenced this pull request in ciaranj/connect-auth Mar 21, 2013

Closed

session not kept between http callbacks #119

@jonathanong jonathanong commented on the diff Oct 26, 2013

lib/middleware/session.js
@@ -17,7 +17,7 @@ var Session = require('./session/session')
, Cookie = require('./session/cookie')
, Store = require('./session/store')
, utils = require('./../utils')
- , parse = utils.parseUrl
+ , parse = require('url').parse
@jonathanong

jonathanong Oct 26, 2013

Contributor

what's the reason for this change?

@jwalton

jwalton Oct 26, 2013

After 8 months? No idea. It certainly looks like it would be safe to revert this line.

Contributor

jonathanong commented Oct 26, 2013

should be fine, just needs a rebase and squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment