Set-Cookie Header getting corrupted because we end up with array inside array #893

Merged
merged 3 commits into from Oct 22, 2013

Conversation

Projects
None yet
4 participants
Contributor

anuj123 commented Sep 12, 2013

Prevents Set-Cookie Header from messing up with one Set-Cookie having multiple cookies because we end up with array inside array

Contributor

fengmk2 commented Sep 13, 2013

Given test code shloud be better.
在 2013-9-13 AM6:30,"anuj123" notifications@github.com写道:

Prevents Set-Cookie Header from messing up with one Set-Cookie having

multiple cookies because we end up with array inside array

You can merge this Pull Request by running

git pull https://github.com/anuj123/connect master

Or view, comment on, or merge it at:

#893
Commit Summary

  • Set-Cookie Header have mupltile cookies as its value while prxiing
    from Node to Rails

File Changes

  • M lib/patch.jshttps://github.com/senchalabs/connect/pull/893/files#diff-0(10)

Patch Links:

Contributor

anuj123 commented Sep 13, 2013

@fengmk2 thanks for pointing it out, I have pushed my test case

Owner

anuj123 commented on lib/patch.js in f4bb567 Sep 16, 2013

if val is an array and prev is string we end up with ["prev", [val] ], This causes one Set-Cookie header to have multiple cookie values

Contributor

jonathanong commented Sep 17, 2013

ideally, this is something that should be fixed in node instead of connect. everything in patch.js should eventually be removed. do you know what the status of this in node is? this could be something to push for in 0.12 since they're overhauling HTTP/S

@ghost ghost assigned tj Oct 2, 2013

jonathanong added a commit that referenced this pull request Oct 22, 2013

Merge pull request #893 from anuj123/master
Set-Cookie Header getting corrupted because we end up with array inside array

@jonathanong jonathanong merged commit 30d8025 into senchalabs:master Oct 22, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment