New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove multipart middleware #924

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@jonathanong
Contributor

jonathanong commented Oct 17, 2013

@andrewrk

This comment has been minimized.

Show comment
Hide comment
@andrewrk

andrewrk Oct 18, 2013

Contributor

25 additions and 700 deletions

Contributor

andrewrk commented Oct 18, 2013

25 additions and 700 deletions

@andrewrk

This comment has been minimized.

Show comment
Hide comment
@andrewrk

andrewrk Oct 18, 2013

Contributor

What are the arguments against doing all the "maybe" stuff from the wiki?

(not sure where this discussion belongs)

Contributor

andrewrk commented Oct 18, 2013

What are the arguments against doing all the "maybe" stuff from the wiki?

(not sure where this discussion belongs)

@jonathanong

This comment has been minimized.

Show comment
Hide comment
@jonathanong

jonathanong Oct 18, 2013

Contributor

well staticCache is basically dead. i think one of the comments have tj saying it is deprecated, but i can't find it so it's a "maybe".

for dropping node 0.8, it's just a matter of when we release 3.0.0. i'd prefer to drop it when 0.12 comes out so we only support the latest 2 versions. but we've dropped node support without a major release so i don't think this really matters.

Contributor

jonathanong commented Oct 18, 2013

well staticCache is basically dead. i think one of the comments have tj saying it is deprecated, but i can't find it so it's a "maybe".

for dropping node 0.8, it's just a matter of when we release 3.0.0. i'd prefer to drop it when 0.12 comes out so we only support the latest 2 versions. but we've dropped node support without a major release so i don't think this really matters.

@dougwilson

This comment has been minimized.

Show comment
Hide comment
@dougwilson

dougwilson Oct 18, 2013

Contributor

@jonathanong The deprecated message is on line 56.

Contributor

dougwilson commented Oct 18, 2013

@jonathanong The deprecated message is on line 56.

@jonathanong

This comment has been minimized.

Show comment
Hide comment
@jonathanong

jonathanong Oct 18, 2013

Contributor

Haha man. I need to read more. I guess it's no longer maybe :D

Contributor

jonathanong commented Oct 18, 2013

Haha man. I need to read more. I guess it's no longer maybe :D

@jonathanong jonathanong deleted the remove-multipart branch Oct 18, 2013

@me-ascii

This comment has been minimized.

Show comment
Hide comment
@me-ascii

me-ascii Oct 19, 2013

Why you removed multipart middleware?

Why you removed multipart middleware?

@jonathanong

This comment has been minimized.

Show comment
Hide comment
@jonathanong

jonathanong Oct 19, 2013

Contributor

it's not removed yet, just deprecated

Contributor

jonathanong commented Oct 19, 2013

it's not removed yet, just deprecated

@ondrek

This comment has been minimized.

Show comment
Hide comment
@ondrek

ondrek Oct 20, 2013

Yep, deprecated.

But thousands of developers have just written in Console, that something is deprecated and they should "visit https://github.com/senchalabs/connect/wiki/Connect-3.0 for alternatives" .. but actually .. that webpage infos quite sucks 🚶 .. Can you specify "Why" and some links maybe to "Issues" .. :)))

.. Instead Multipart Middleware are three alternatives (first with 3 commits and second is deprecated by author), and "Maybe .. Remove node 0.8 support" .. what are no so smaaaal steps ;D

ondrek commented Oct 20, 2013

Yep, deprecated.

But thousands of developers have just written in Console, that something is deprecated and they should "visit https://github.com/senchalabs/connect/wiki/Connect-3.0 for alternatives" .. but actually .. that webpage infos quite sucks 🚶 .. Can you specify "Why" and some links maybe to "Issues" .. :)))

.. Instead Multipart Middleware are three alternatives (first with 3 commits and second is deprecated by author), and "Maybe .. Remove node 0.8 support" .. what are no so smaaaal steps ;D

@jonathanong

This comment has been minimized.

Show comment
Hide comment
@jonathanong

jonathanong Oct 20, 2013

Contributor

yeah, i'll add some reasons

i wouldn't worry about dropping node 0.8 though. connect 3.0 will probably be released after node v0.12 is out

Contributor

jonathanong commented Oct 20, 2013

yeah, i'll add some reasons

i wouldn't worry about dropping node 0.8 though. connect 3.0 will probably be released after node v0.12 is out

@ondrek

This comment has been minimized.

Show comment
Hide comment
@ondrek

ondrek Oct 20, 2013

💛 thank you :)

ondrek commented Oct 20, 2013

💛 thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment