Skip to content

fix: Modify the incorrect stringSet on the Banned user list #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix: Modify the incorrect stringSet on the Banned user list #1008

merged 1 commit into from
Mar 14, 2024

Conversation

@HoonBaek
Copy link
Contributor

@HoonBaek HoonBaek commented Mar 13, 2024 •
edited by atlassian bot
Loading

SBISSUE-15260

ChangeLog & Fix

  • Modify the incorrect stringSet on the BannedUsersModal
    • CHANNEL_SETTING__MUTED_MEMBERS__TITLE to CHANNEL_SETTING__BANNED_MEMBERS__TITLE
    • CHANNEL_SETTING__MODERATION__BAN to CHANNEL_SETTING__MODERATION__UNBAN
    • also fixed the dataSbId of the MenuItem: channel_setting_banned_user_context_menu_ban to channel_setting_banned_user_context_menu_unban

@HoonBaek HoonBaek self-assigned this Mar 13, 2024
chohongm
chohongm approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@chohongm chohongm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HoonBaek HoonBaek merged commit cc526e3 into main Mar 14, 2024
@HoonBaek HoonBaek deleted the fix/CLNP-2528/Modify-incorrect-string-set branch March 14, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AhyoungRyu AhyoungRyu Awaiting requested review from AhyoungRyu

@bang9 bang9 Awaiting requested review from bang9

1 more reviewer

@chohongm chohongm chohongm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@HoonBaek HoonBaek

Labels

v3.13.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HoonBaek @chohongm