Skip to content

fix: Replace the root components order #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2024
Merged

fix: Replace the root components order #1026

merged 2 commits into from
Mar 22, 2024

Conversation

@HoonBaek
Copy link
Contributor

@HoonBaek HoonBaek commented Mar 22, 2024 •
edited
Loading

Fix

  • Replace the root components order because dropdown menu is hided by modals

before
image

after
image

@HoonBaek HoonBaek requested a review from chohongm March 22, 2024 07:16
@HoonBaek HoonBaek self-assigned this Mar 22, 2024
chohongm
chohongm approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@chohongm chohongm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HoonBaek HoonBaek merged commit 7f17963 into main Mar 22, 2024
@HoonBaek HoonBaek deleted the fix/Replace-the-roots-order branch March 22, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chohongm chohongm chohongm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@HoonBaek HoonBaek

Labels

v3.13.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HoonBaek @chohongm