From 60da6b28d9557d8307fe59cacf4921175eaa3caf Mon Sep 17 00:00:00 2001 From: Liam Hongman Cho Date: Tue, 2 Apr 2024 16:58:38 +0900 Subject: [PATCH 1/3] 1. fix default profile not showing issue 2. fix scroll displayed in message sender title container --- src/ui/ImageRenderer/index.tsx | 2 +- src/ui/MessageContent/index.scss | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ui/ImageRenderer/index.tsx b/src/ui/ImageRenderer/index.tsx index 1e4b0fbd3..973197e42 100644 --- a/src/ui/ImageRenderer/index.tsx +++ b/src/ui/ImageRenderer/index.tsx @@ -135,7 +135,7 @@ const ImageRenderer = ({ }} > {placeholderVisible && renderPlaceholder()} - {defaultComponentVisible ? renderDefault() : renderImage()} + {(!internalUrl || defaultComponentVisible) ? renderDefault() : renderImage()} {shadeOnHover && (
Date: Wed, 3 Apr 2024 16:42:56 +0900 Subject: [PATCH 2/3] snapshot fix --- .../__snapshots__/Avatar.spec.js.snap | 30 +++++++++++++++---- .../__snapshots__/MessageContent.spec.js.snap | 15 ++++++++-- .../OGMessageItemBody.spec.js.snap | 14 +++++++-- 3 files changed, 47 insertions(+), 12 deletions(-) diff --git a/src/ui/Avatar/__tests__/__snapshots__/Avatar.spec.js.snap b/src/ui/Avatar/__tests__/__snapshots__/Avatar.spec.js.snap index 29941c75a..e8fda54dd 100644 --- a/src/ui/Avatar/__tests__/__snapshots__/Avatar.spec.js.snap +++ b/src/ui/Avatar/__tests__/__snapshots__/Avatar.spec.js.snap @@ -58,9 +58,18 @@ exports[`ui/Avatar should do a snapshot test of the Avatar DOM with four element style="width: 100%; min-width: min(400px, 56px); max-width: 400px;" >
+ class="sendbird-avatar-img--default " + style="width: 56px; height: 56px;" + > +
+ +
+
@@ -212,9 +221,18 @@ exports[`ui/Avatar should render default image if src is empty 1`] = ` style="width: 100%; min-width: min(400px, 56px); max-width: 400px;" >
+ class="sendbird-avatar-img--default " + style="width: 56px; height: 56px;" + > +
+ +
+
diff --git a/src/ui/MessageContent/__tests__/__snapshots__/MessageContent.spec.js.snap b/src/ui/MessageContent/__tests__/__snapshots__/MessageContent.spec.js.snap index f755329f1..b63657108 100644 --- a/src/ui/MessageContent/__tests__/__snapshots__/MessageContent.spec.js.snap +++ b/src/ui/MessageContent/__tests__/__snapshots__/MessageContent.spec.js.snap @@ -23,9 +23,18 @@ exports[`ui/MessageContent should do a snapshot test of the MessageContent DOM 1 style="width: 100%; min-width: min(400px, 28px); max-width: 400px;" >
+ class="sendbird-avatar-img--default " + style="width: 28px; height: 28px;" + > +
+ +
+
diff --git a/src/ui/OGMessageItemBody/__tests__/__snapshots__/OGMessageItemBody.spec.js.snap b/src/ui/OGMessageItemBody/__tests__/__snapshots__/OGMessageItemBody.spec.js.snap index 116c3a9d3..4eda22239 100644 --- a/src/ui/OGMessageItemBody/__tests__/__snapshots__/OGMessageItemBody.spec.js.snap +++ b/src/ui/OGMessageItemBody/__tests__/__snapshots__/OGMessageItemBody.spec.js.snap @@ -24,9 +24,17 @@ exports[`ui/OGMessageItemBody should do a snapshot test of the OGMessageItemBody style="width: 100%; min-width: min(400px, 100%); max-width: 400px;" >
+ class="sendbird-og-message-item-body__og-thumbnail__place-holder" + > +
+ +
+
Date: Thu, 4 Apr 2024 11:52:27 +0900 Subject: [PATCH 3/3] fix test --- src/ui/ChannelAvatar/__tests__/ChannelAvatar.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ui/ChannelAvatar/__tests__/ChannelAvatar.spec.js b/src/ui/ChannelAvatar/__tests__/ChannelAvatar.spec.js index bea2e96ff..dc7ed9617 100644 --- a/src/ui/ChannelAvatar/__tests__/ChannelAvatar.spec.js +++ b/src/ui/ChannelAvatar/__tests__/ChannelAvatar.spec.js @@ -8,7 +8,7 @@ describe('ui/ChannelAvatar', () => { it('should render a normal default channel avatar', function() { const targetClassName = "sendbird-chat-header--avatar--group-channel"; render(); - expect(screen.getByRole('button').className).toContain(targetClassName); + expect(screen.getAllByRole('button')[0].className).toContain(targetClassName); }); it('should render a default avatar of broadcastChannel', function() {