From c0bee8a8687f49e7dea9ba87c8106f141e87c32c Mon Sep 17 00:00:00 2001 From: Sravan S Date: Fri, 30 Sep 2022 16:26:46 +0900 Subject: [PATCH] [v3.2.1] (Oct 02 2022) Fixes: * Do not bundle chat SDK with uikit compiled code Compiled UIKit code that is distributed through npm shouldn't have Chat SDK minified code included in it Chat SDK should be a dependency of UIKit Advantages: * Chat SDK bug fixes will be added for free * Eliminate the need for handlers What caused the issue: If you are using rollup for bundling in config.external you have to be specific ie> This works: ``` external: [ '@sendbird/chat', '@sendbird/chat/groupChannel', '@sendbird/chat/openChannel', '@sendbird/chat/message', ] ``` This doesn't: ``` external: [ '@sendbird/chat', ] ``` * Only react and react-dom should be peerDependencies For npm >= v7, npm autoinstall peerDependency packages According to `https://docs.npmjs.com/cli/v8/configuring-npm/package-json#peerdependencies` You want to express the compatibility of your package with a host tool or library while not necessarily doing a require of this host Even though react is required, its better to show that react is the host tool --- CHANGELOG.md | 38 ++++++++++++++++++++++++++++++++++++++ package-lock.json | 4 ++-- package.json | 2 +- 3 files changed, 41 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e4b4456e9..c8f579740 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,43 @@ # Changelog - v3 +## [v3.2.1] (Oct 02 2022) + +Fixes: + +* Do not bundle chat SDK with uikit compiled code + +Compiled UIKit code that is distributed through npm shouldn't +have Chat SDK minified code included in it +Chat SDK should be a dependency of UIKit +Advantages: + * Chat SDK bug fixes will be added for free + * Eliminate the need for handlers +What caused the issue: +If you are using rollup for bundling +in config.external you have to be specific +ie> +This works: +``` +external: [ + '@sendbird/chat', + '@sendbird/chat/groupChannel', + '@sendbird/chat/openChannel', + '@sendbird/chat/message', +] +``` +This doesn't: +``` +external: [ '@sendbird/chat', ] +``` + +* Only react and react-dom should be peerDependencies + +For npm >= v7, npm autoinstall peerDependency packages +According to `https://docs.npmjs.com/cli/v8/configuring-npm/package-json#peerdependencies` +You want to express the compatibility of your package with a host tool +or library while not necessarily doing a require of this host Even though react is required, +its better to show that react is the host tool + ## [v3.2.0] (Sep 27 2022) Features: diff --git a/package-lock.json b/package-lock.json index a8528561c..f6cd6665e 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@sendbird/uikit-react", - "version": "3.2.0", + "version": "3.2.1", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@sendbird/uikit-react", - "version": "3.2.0", + "version": "3.2.1", "license": "SEE LICENSE IN LICENSE.md", "dependencies": { "@sendbird/chat": "^4.0.13", diff --git a/package.json b/package.json index a802c9057..93ee757a2 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@sendbird/uikit-react", - "version": "3.2.0", + "version": "3.2.1", "description": "React based UI kit for sendbird", "main": "dist/index.js", "style": "dist/index.css",