Skip to content

Conversation

@HoonBaek
Copy link
Contributor

@HoonBaek HoonBaek commented Jun 23, 2023

Description Of Changes

  • fix: move scroll every time when message height changes
    • prev: moving scroll only when the last message height changes

UIKIT-4042

@HoonBaek HoonBaek self-assigned this Jun 23, 2023
@HoonBaek HoonBaek requested a review from sravan-s June 23, 2023 02:35
if (current) {
const bottom = current.scrollHeight - current.scrollTop - current.offsetHeight;
if (scrollBottom < bottom) {
// Move the scroll as much as the height of the message has changed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@HoonBaek HoonBaek merged commit bf313ba into main Jun 23, 2023
@HoonBaek HoonBaek deleted the fix/UIKIT-4042/move-scroll-when-message-height-changes branch June 23, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants