From 838c2cbaa58de9a527879317ee45f12e8831f6e2 Mon Sep 17 00:00:00 2001 From: HoonBaek Date: Fri, 15 Dec 2023 14:50:06 +0900 Subject: [PATCH 1/2] Include metaArray to the message list when fetching messages again by reconnect --- src/hooks/VoicePlayer/useVoicePlayer.tsx | 9 ++++++--- src/lib/hooks/useOnlineStatus.ts | 1 - src/modules/Channel/context/hooks/useHandleReconnect.ts | 1 + 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/hooks/VoicePlayer/useVoicePlayer.tsx b/src/hooks/VoicePlayer/useVoicePlayer.tsx index 1a18f0857..b77465f06 100644 --- a/src/hooks/VoicePlayer/useVoicePlayer.tsx +++ b/src/hooks/VoicePlayer/useVoicePlayer.tsx @@ -70,9 +70,12 @@ export const useVoicePlayer = ({ play: playVoicePlayer, pause: pauseVoicePlayer, stop: stopVoicePlayer, - playbackTime: currentAudioUnit.playbackTime * 1000, - duration: currentAudioUnit.duration * 1000, - // the unit of playbackTime and duration should be millisecond + /** + * The reason why we multiply this by *1000 is, + * The unit of playbackTime and duration should be millisecond + */ + playbackTime: (currentAudioUnit?.playbackTime || 0) * 1000, + duration: (currentAudioUnit?.duration || 0) * 1000, playingStatus: currentAudioUnit.playingStatus, }); }; diff --git a/src/lib/hooks/useOnlineStatus.ts b/src/lib/hooks/useOnlineStatus.ts index 75f4ec7ab..81690acf2 100644 --- a/src/lib/hooks/useOnlineStatus.ts +++ b/src/lib/hooks/useOnlineStatus.ts @@ -20,7 +20,6 @@ function useOnlineStatus(sdk: SendbirdChat, logger: LoggerInterface) { onReconnectStarted() { setIsOnline(false); logger.warning('onReconnectStarted', { isOnline }); - }, onReconnectSucceeded() { setIsOnline(true); diff --git a/src/modules/Channel/context/hooks/useHandleReconnect.ts b/src/modules/Channel/context/hooks/useHandleReconnect.ts index 45ab2f5e2..12476c07d 100644 --- a/src/modules/Channel/context/hooks/useHandleReconnect.ts +++ b/src/modules/Channel/context/hooks/useHandleReconnect.ts @@ -54,6 +54,7 @@ function useHandleReconnect( prevResultSize: PREV_RESULT_SIZE, isInclusive: true, includeReactions: isReactionEnabled, + includeMetaArray: true, nextResultSize: NEXT_RESULT_SIZE, }; if (replyType && replyType === 'QUOTE_REPLY') { From 6f3a93d3cd3fb2c4596046f83e186894bb5a56d5 Mon Sep 17 00:00:00 2001 From: HoonBaek Date: Fri, 15 Dec 2023 14:54:53 +0900 Subject: [PATCH 2/2] fix lint error --- src/hooks/VoicePlayer/useVoicePlayer.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hooks/VoicePlayer/useVoicePlayer.tsx b/src/hooks/VoicePlayer/useVoicePlayer.tsx index b77465f06..77b9151d5 100644 --- a/src/hooks/VoicePlayer/useVoicePlayer.tsx +++ b/src/hooks/VoicePlayer/useVoicePlayer.tsx @@ -75,7 +75,7 @@ export const useVoicePlayer = ({ * The unit of playbackTime and duration should be millisecond */ playbackTime: (currentAudioUnit?.playbackTime || 0) * 1000, - duration: (currentAudioUnit?.duration || 0) * 1000, + duration: (currentAudioUnit?.duration || 0) * 1000, playingStatus: currentAudioUnit.playingStatus, }); };