Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added "Code Review" section to CONTRIBUTING.md #65

Merged
merged 3 commits into from Oct 29, 2018

Conversation

aleien
Copy link
Contributor

@aleien aleien commented Oct 31, 2017

Fixes #64

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Added "Code Reviews" section as #64 suggests.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 31, 2017

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@mrmuskrat mrmuskrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@thinkingserious
Copy link
Contributor

@aleien

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@aleien
Copy link
Contributor Author

aleien commented Nov 2, 2017 via email

@thinkingserious
Copy link
Contributor

Thanks for your help @JessedB!

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code labels Mar 6, 2018
Copy link

@jonjenkins jonjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonjenkins jonjenkins added status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Oct 22, 2018
@thinkingserious thinkingserious merged commit 51e27de into sendgrid:master Oct 29, 2018
@thinkingserious
Copy link
Contributor

Hello @aleien,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@thinkingserious thinkingserious changed the title Added "Code Review" section to CONTRIBUTING.md docs: added "Code Review" section to CONTRIBUTING.md Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code
Projects
None yet
7 participants