Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please use a golint tool #64

Closed
vvakame opened this issue Jun 17, 2016 · 3 comments · Fixed by #148
Closed

Please use a golint tool #64

vvakame opened this issue Jun 17, 2016 · 3 comments · Fixed by #148
Labels
difficulty: medium fix is medium in difficulty status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap

Comments

@vvakame
Copy link

vvakame commented Jun 17, 2016

Issue Summary

golint is very useful tool.
please try it!

Steps to Reproduce

  1. go get -u github.com/golang/lint/golint
  2. golint ./...
  3. You got a lot of error!
    e.g... helpers/mail/mail_v3.go:28:6: exported type Personalization should have comment or be unexported
    I want to read the doc comment.

Technical details:

  • sendgrid-go Version: master (latest commit: 21f0869)
  • Go Version: go version go1.6.2 darwin/amd64
@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap status: help wanted requesting help from the community labels Jun 17, 2016
@thinkingserious
Copy link
Contributor

Hello @vvakame,

Thank you for the suggestion!

These are our current Style Guide & Naming Conventions: https://github.com/sendgrid/sendgrid-go/blob/master/CONTRIBUTING.md#style-guidelines--naming-conventions

I will leave this ticket open for consideration to add.

With Best Regards,

Elmer

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty hacktoberfest difficulty: medium fix is medium in difficulty and removed difficulty: easy fix is easy in difficulty labels Oct 1, 2017
@srini156
Copy link
Contributor

srini156 commented Oct 2, 2017

@thinkingserious - Please have a look at this - https://goreportcard.com/report/github.com/sendgrid/sendgrid-go

Let me know if this is something you're looking to add. I would definitely love to contribute.

@thinkingserious
Copy link
Contributor

Thanks @srini156!

@suchitparikh what do you think?

@srini156 srini156 mentioned this issue Oct 3, 2017
Merged
@prateekpandey14 prateekpandey14 mentioned this issue Oct 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing golint and gofmt errors prateekpandey14/sendgrid-go
3 participants
@vvakame @thinkingserious @srini156