Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Shrinkwrap dependencies not working with Node 0.8 #37

Closed
mbuchetics opened this Issue Jun 28, 2012 · 5 comments

Comments

Projects
None yet
3 participants

In your npm shrinkwrap file you are referencing mocha at version 1.2.0, which is not compatible with node 0.8. Newer versions of mocha work fine. Your shrinkwrap also contains outdated version information about your own package (0.2.2 instead of 0.2.3).

Do you really need the shrinkwrap at all? Why is the package.json not sufficient in your case?

Contributor

theycallmeswift commented Jun 28, 2012

We just patched a bug where the SMTP api wasn't working because the API changed for one of our underlying dependencies (should have been a major version bump, but it wasn't). The shrinkwrap is an effort to keep things sane.

Update is in the works.

Contributor

theycallmeswift commented Jun 28, 2012

After further investigation, it looks like mocha hasn't published a patched version of their package yet (1.2.2 will be node 0.8.0 compatible). This is on hold until then.

catilac commented Jul 27, 2012

There is a new patch out for mocha. Can you update to 1.3.0 so that I can install this for my node 0.8.3 application?
https://github.com/visionmedia/mocha/blob/master/package.json#L10

Contributor

theycallmeswift commented Jul 27, 2012

Fixed and published. Thanks for the heads up

catilac commented Jul 27, 2012

Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment