Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Upgrade nodemailer dependencies and document tests #36

merged 2 commits into from Jun 22, 2012


None yet
2 participants

theycallmeswift commented Jun 21, 2012

This contains two changes:

  1. The nodemailer API changed recently, I updated our implementation to use the new API

    Anyone who does an npm install on the current library will have broken SMTP support. I also had to patch one of the dependencies (mimelib), which was returning an object instead of an array and causing our tests to fail. (andris9/mimelib@a1bdf17)

    Also, included a shrinkwrap.js to prevent this from happening in the future.

  2. Updated the tests and documents them

    I updated our test command to use the local copy of mocha instead of the system copy. Also, changed the test/test.setup file to be test/config.js since that's a standard.

This should be a patch level version bump, since it wasn't our API that changed. Also, we should start enforcing strict dependency versioning since this is an open source project.

theycallmeswift added some commits Jun 21, 2012

@theycallmeswift theycallmeswift Cleaned up and documented the tests.
This commit includes the following changes:

 - Renamed `test/test.setup` -> `test/config.js` to match standard
 - Changed Makefile to use the local copy of mocha (recursive)
 - Wrote docs for running the tests
@theycallmeswift theycallmeswift Updated SMTP functions to use the newest version of the nodemailer API.
Nodemailer's API changed recently, so sending via SMTP will be broken
for anyone who installs the package in its current state.  Also, added a
shrinkwrap file to prevent this from happening in the future.

@brandonmwest brandonmwest added a commit that referenced this pull request Jun 22, 2012

@brandonmwest brandonmwest Merge pull request #36 from sendgrid/upgrade-nodemailer-dependencies
Upgrade nodemailer dependencies and document tests

@brandonmwest brandonmwest merged commit e7f9c1c into master Jun 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment