Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

added charset functionality #10

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

daarond commented Dec 7, 2012

The extra files are from PhpStorm, feel free to delete them.

Contributor

motdotla commented Jul 8, 2013

Hi @daarond - thank you for this, but please re-submit without the PhpStorm files and more importantly with a commit change that doesn't show an entire deletion and then re-addition of of the Mail.php and Smtp.php. It's not ideal to have a diff that shows the entire file changing - when really it was only the addition of the charset portions.

Please submit as a separate pull request. I'm closing this one.

Probably the best thing is to delete your fork, and then re-fork from current master. Then re-add the charset changes you added.

@motdotla motdotla closed this Jul 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment