Skip to content

Conversation

@int-ua
Copy link
Contributor

@int-ua int-ua commented Jul 9, 2019

Fixes #808

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them
  • I updated my branch with the master branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

I won't spend much time reading all the guides for this small change, feel free to reject this PR and write it in your own words.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jul 9, 2019
@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #821 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #821   +/-   ##
=======================================
  Coverage   80.02%   80.02%           
=======================================
  Files          70       70           
  Lines        2018     2018           
  Branches      339      339           
=======================================
  Hits         1615     1615           
  Misses        204      204           
  Partials      199      199

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 610e933...ca962f2. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #821 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #821   +/-   ##
=======================================
  Coverage   80.02%   80.02%           
=======================================
  Files          70       70           
  Lines        2018     2018           
  Branches      339      339           
=======================================
  Hits         1615     1615           
  Misses        204      204           
  Partials      199      199

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 610e933...ca962f2. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #821 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #821   +/-   ##
=======================================
  Coverage   80.02%   80.02%           
=======================================
  Files          70       70           
  Lines        2018     2018           
  Branches      339      339           
=======================================
  Hits         1615     1615           
  Misses        204      204           
  Partials      199      199

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 610e933...c15b316. Read the comment docs.

@thinkingserious thinkingserious merged commit 021a9dc into sendgrid:master Sep 11, 2019
@thinkingserious
Copy link
Contributor

Hello @int-ua,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code labels Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: docs update documentation change not affecting the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updating a campiagn's content

2 participants