From 2cff2c96e4c1e745fb0d20f51d6ce17b6450d3e3 Mon Sep 17 00:00:00 2001 From: Random Hacktoberfest Participant <32420862+random-hacktoberfest-participant-2017@users.noreply.github.com> Date: Thu, 26 Oct 2017 21:55:14 +0100 Subject: [PATCH 1/2] Create PULL_REQUEST_TEMPLATE.md --- .github/PULL_REQUEST_TEMPLATE.md | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000..c83c997 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,31 @@ + + +**Description of the change**: + +**Reason for the change**: + +**Link to original source**: + +### Checklist + +Make sure all of these items are complete, or else the PR will be ineligible for a code review. + +- [ ] Code passes all existing [tests](https://github.com/sendgrid/smtpapi-python/tree/master/test) +- [ ] Any new functionality added includes new unit tests in [`tests/__init__.py`](https://github.com/sendgrid/smtpapi-python/blob/master/test/__init__.py) +- [ ] Create or update example code to show the new functionality in action. +- [ ] All code, branch, and git naming and style conventions are followed (see [`CONTRIBUTING.md`](https://github.com/sendgrid/smtpapi-python/blob/master/CONTRIBUTING.md#style-guidelines-and-naming-conventions)) +- [ ] Feature branch has been rebased off of the latest `master` branch. ( see [`CONTRIBUTING.md`](https://github.com/sendgrid/smtpapi-python/blob/master/CONTRIBUTING.md#creating-a-pull-request) ). + +If you have questions, please send an email [Sendgrid](mailto:dx@sendgrid.com), or file a Github Issue in this repository. From 34c2628da371750982e1c479d048520c3693701d Mon Sep 17 00:00:00 2001 From: Matt Bernier Date: Sat, 28 Oct 2017 12:03:58 -0600 Subject: [PATCH 2/2] Update and rename PULL_REQUEST_TEMPLATE.md to PULL_REQUEST_TEMPLATE --- .github/PULL_REQUEST_TEMPLATE | 24 ++++++++++++++++++++++++ .github/PULL_REQUEST_TEMPLATE.md | 31 ------------------------------- 2 files changed, 24 insertions(+), 31 deletions(-) create mode 100644 .github/PULL_REQUEST_TEMPLATE delete mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE new file mode 100644 index 0000000..7ad590b --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE @@ -0,0 +1,24 @@ + +# Fixes # + +### Checklist +- [ ] I have made a material change to the repo (functionality, testing, spelling, grammar) +- [ ] I have read the [Contribution Guide] and my PR follows them. +- [ ] I updated my branch with the master branch. +- [ ] I have added tests that prove my fix is effective or that my feature works +- [ ] I have added necessary documentation about the functionality in the appropriate .md file +- [ ] I have added in line documentation to the code I modified + +### Short description of what this PR does: +- +- + +If you have questions, please send an email to [Sendgrid](mailto:dx@sendgrid.com), or file a Github Issue in this repository. diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md deleted file mode 100644 index c83c997..0000000 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ /dev/null @@ -1,31 +0,0 @@ - - -**Description of the change**: - -**Reason for the change**: - -**Link to original source**: - -### Checklist - -Make sure all of these items are complete, or else the PR will be ineligible for a code review. - -- [ ] Code passes all existing [tests](https://github.com/sendgrid/smtpapi-python/tree/master/test) -- [ ] Any new functionality added includes new unit tests in [`tests/__init__.py`](https://github.com/sendgrid/smtpapi-python/blob/master/test/__init__.py) -- [ ] Create or update example code to show the new functionality in action. -- [ ] All code, branch, and git naming and style conventions are followed (see [`CONTRIBUTING.md`](https://github.com/sendgrid/smtpapi-python/blob/master/CONTRIBUTING.md#style-guidelines-and-naming-conventions)) -- [ ] Feature branch has been rebased off of the latest `master` branch. ( see [`CONTRIBUTING.md`](https://github.com/sendgrid/smtpapi-python/blob/master/CONTRIBUTING.md#creating-a-pull-request) ). - -If you have questions, please send an email [Sendgrid](mailto:dx@sendgrid.com), or file a Github Issue in this repository.