Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yoast Adds More bloat #19

Closed
jakejackson1 opened this issue Oct 6, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@jakejackson1
Copy link

commented Oct 6, 2016

Looks like a "Go Premium" sub menu has been added under the main SEO menu. I probably wouldn't have noticed it if it wasn't for the big orange star also included.

@jakejackson1 jakejackson1 changed the title Yoast 3.5 Adds More bloat Yoast Adds More bloat Oct 6, 2016

@senlin senlin added the question label Oct 6, 2016

@senlin

This comment has been minimized.

Copy link
Owner

commented Oct 6, 2016

Hi Jake,
Thanks for your suggestion. Are you suggesting to include a setting that removes the star?

@jakejackson1

This comment has been minimized.

Copy link
Author

commented Oct 6, 2016

A "Premium" tab specifically for upselling and provides no value to the open source plugin seems like bloat to me.

@senlin senlin added enhancement and removed question labels Oct 6, 2016

@senlin

This comment has been minimized.

Copy link
Owner

commented Oct 6, 2016

Hmmm, I find this a tricky one, especially since the proposed guidelines sort of encourage in-plugin advertising for premium services.

The tab is not hijacking the dashboard or the rest of the plugin and you don't have to click on the tab as it clearly says what you can expect.

I am much more inclined to remove the star though as that is unnecessary attention seeking.

Here's what I will do: I will add a new option that hides the red star by default and offer the option to hide the entire submenu. ok skip that, I had a look at how things are coded there and that is going to be a lot of effort. Feel free to have a look and if you have a solution then I will happily accept your PR!

File responsible for adding the Go Premium submenu: admin/class-admin.php (the entire code block from L128-L260)

Would that work for you?

senlin pushed a commit that referenced this issue Oct 6, 2016

senlin pushed a commit that referenced this issue Oct 6, 2016

Piet Bos
commit version 2.5.0
* release date 2016.10.06
* remove tour setting (redundant since v3.6 of Yoast SEO)
* remove adminbar setting (redundant since v3.6 of Yoast SEO)
* add new setting that hides the red star behind the "Go Premium"
submenu that was added in v3.6 of Yoast SEO (it is probably necessary
to save the settings page for this change to take effect). Thanks to
Jake Jackson for reporting [this
issue](#19).

@senlin senlin closed this Oct 6, 2016

@jakejackson1

This comment has been minimized.

Copy link
Author

commented Oct 6, 2016

Sounds great. A setting to optionally disable that menu item would also be excellent and would compliment the other inline advertising you can disable. If I get some free time I'll look at a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.