Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

eclim-problem-correct doesn't work with get/set solution #96

Closed
skybert opened this Issue Mar 27, 2013 · 6 comments

Comments

Projects
None yet
3 participants

skybert commented Mar 27, 2013

Hi,

eclim-problem-correct is excellent! I use it in the java buffers, just as I would fix my code in IDEA or Eclipse. Who would have thought we could do this in Emacs. Amazing! Unfortunately, it doesn't work for the get/set generation. There's no error, but also no insertion of get/set methods.

To reproduce this, have an unused member field, say:

public class App {
   private String name;
}

Then do eclim-problems-correct and choose 1 (which is Correction 1: Create getter and setter for 'name'...). Nothing happens. All other corrections I have tried work.

eclim: 2.2.5.67
eclim-emacs: from master @ 2013-03-27
emacs: GNU Emacs 24.3.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.4.2) of 2013-03-25 on dex, modified by Debian
Collaborator

fred-o commented Apr 4, 2013

Unfortunately, this seems to be a limitation in the eclim server. If you try to perform the same correction from inside eclipse it pops up a dialog box, and I suspect that eclim has problems handling that particular case.

nerton commented Apr 7, 2013

@skybert report it on the eclim devel list if you haven't yet done so: https://groups.google.com/forum/?fromgroups#!forum/eclim-dev

They use VIM as a client, so mention there only the relevant Java code for which no correction is offered. If they fix it in the server then it will work in the emacs client too.

skybert commented Apr 8, 2013

@fred-o yes, you're right of course. I've created an issue on eclim [1] as @nerton suggested.

Cheers!

[1] ervandew/eclim#209

skybert commented Apr 11, 2013

Over at eclim, @ervandew has added the get/set solution to the filter of solutions that are not returned by eclim since they require GUI interaction, so this is - for the foreseeable future at least - the way it'll go with these kind of Eclipse features.

For generating getters/setters, eclim provides a dedicated function (java_bean_properties), though. It looks like this has not yet been added to emacs-eclim.

Collaborator

fred-o commented May 6, 2013

Cool. I've merged your pull req.

skybert commented May 10, 2013

Great stuff.

Good thing you addedrevert-buffer to eclim-java-generate-getter-and-setter I forgot I have this set globally in my .emacs.

@skybert skybert closed this May 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment