Remove redundant prefix from candidates. #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! You we're very productive today. Great |
This is to fix the issue where if you complete 'java.uti' it will end up inserting 'java.java.util'. This is because the completion prefix in this example is 'uti', but the candidate returned by eclim will be the full package name 'java.util'. Company will insert the completion from the prefix, which leads to the incorrect behavior. This solves this issue by looking before the prefix at what is already present in the buffer, and removing and redundancy from candidates if present.
|
I just updated the pull request. It now will ignore errors when searching for the existing package name in the buffer. Without this it was breaking completion if there wasn't a symbol immediately before the prefix. I also added checks to ensure that the package name is non-nil and not the empty string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #162, where if you complete 'java.uti' it will end up
inserting 'java.java.util'. This is because the completion prefix in
this example is 'uti', but the candidate returned by eclim will be the
full package name 'java.util'. Company will insert the completion from
the prefix, which leads to the incorrect behavior. This solves this
issue by looking before the prefix at what is already present in the
buffer, and removing and redundancy from candidates if present.