Make our after-save-hook be local #93

Merged
merged 2 commits into from Mar 25, 2013

3 participants

@expez

No description provided.

expez added some commits Mar 25, 2013
@expez expez Make after-save-hook local.
Eclim spam in the modeline just because I have eclim installed is
annoying.  Can fix this by making the after-save-hook local to buffers
where eclim is activated.
28b0b56
@expez expez Minor refactoring.
- There's not point in setting a value to its default.  In any event, we
  should probably not just setq variables like this because it affects
  the global session.  We should instead use global variables.

- The if-progn idiom is so common that someone made a macro for it a
  long time ago.  It's also good style to use WHEN/UNLESS if there's no
  ELSE clause.

- We should be consistent when we retrieve the function to add to a
  hook.  While #'function is technically more correct, nobody bothers
  using this form, so we'll favor the other one.
a45fe2c
@senny
Owner

looks good. Thanks for your contribution!

/cc @fred-o

@fred-o fred-o merged commit a45fe2c into senny:master Mar 25, 2013
@expez expez deleted the expez:local-hooks branch Mar 25, 2013
@fred-o
Collaborator

Agreed. Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment