Yves Senn senny

Organizations

@rails @4teamwork @ruvetia
senny commented on pull request rails/rails-perftest#13
@senny

@eliotsykes thank you :yellow_heart:

@senny
senny merged pull request rails/rails-perftest#13
@senny
Upgrade links to https and include Skylight
1 commit with 4 additions and 3 deletions
senny pushed to master at rails/rails
@senny
@senny
  • @senny 9a8757f
    Merge pull request #19595 from claudiob/fix-docs-set-callback
senny commented on pull request rails/rails#19595
@senny

@claudiob thanks man! :yellow_heart:

senny merged pull request rails/rails#19595
@senny
Fix doc: set_callback also accepts an array of if:
1 commit with 6 additions and 4 deletions
senny commented on pull request rails/rails#19595
@senny

A think we should not quote true as we are referring to Ruby's definition of a "true value" and not the exact value true.

senny pushed to master at rails/rails
@senny
senny commented on pull request rails/rails#19523
@senny

@kuldeepaggarwal thank you :yellow_heart:

senny merged pull request rails/rails#19523
@senny
rename `widgets` table to `new_widgets`
1 commit with 4 additions and 2 deletions
senny commented on pull request rails/rails#19523
@senny

:scissors:

senny commented on pull request rails/rails-perftest#13
@senny

@eliotsykes can you please squash your commits?

senny commented on pull request rails/rails#18719
@senny

@rafaeladel can you publish a minimal sample engine that exhibits this problem? Maybe check wether a newly generated one has it as well.

senny commented on pull request rails/rails#18719
@senny

@rafaeladel did you update your test_helper.rb according to this patch? This PR modifies a template used when you generate the engine.

senny commented on pull request rails/rails#19523
@senny

@kuldeepaggarwal the reset_column_information should happen in an ensure as cleanup, not in advance: here: https://github.com/rails/rails/blob/e2a…

senny commented on pull request rails/rails#19584
@senny

@kirs in the original PR we have discussed this already. We decided to keep it simple and only support directory and file arguments. You can follow…

senny closed pull request rails/rails#19584
@senny
Make the test runner support `rails test controllers`
senny commented on pull request rails/rails#19523
@senny

Instead of changing the table name to prevent the collision, we should use widget.reset_column_information. The thing is that this method clears th…

senny commented on pull request rails/rails#19518
@senny

@DianthuDia Please open a new PR against master. The merger will backport the fix to the maintained release branches. Thank you :yellow_heart:

senny closed pull request rails/rails#19518
@senny
Fix unscope for less than
senny pushed to master at rails/rails
@senny
senny commented on pull request rails/rails#19540
@senny

@y-yagi thank you :yellow_heart:

senny merged pull request rails/rails#19540
@senny
respect `pluralize_table_names` when generate fixture file. fixes #19519
1 commit with 21 additions and 1 deletion
senny closed issue rails/rails#19519
@senny
generated fixture filename for model ignores ActiveRecord::Base.pluralize_table_names = false
senny commented on pull request rails/rails#19540
@senny

Instead of file_name.pluralize we can stick to plural_file_name.

senny commented on pull request rails/rails#19540
@senny

@y-yagi looks good, can you add an entry to the CHANGELOG?

senny commented on pull request rails/rails#19540
@senny

it's better to use a local variable instead of hardcoding the default value: original_pluralize_table_name = ActiveRecord::Base.pluralize_table_names

senny commented on pull request rails/rails#19535
@senny

@kaspth the methods are #:nodoc'd and not targeting users. How useful they are is certainly debatable but they were introduced by the original auth…

senny pushed to master at rails/rails
@senny