Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wopi Edit action should not be available on old Office files. #627

Closed
tusmester opened this issue Jun 18, 2019 · 1 comment

Comments

@tusmester
Copy link
Member

commented Jun 18, 2019

WopiOpenAction decides whether the action is available based on the permissions of the current user and the extension of the file. In case of doc (not docx) files this is not enough, because they can be viewed but not edited.

The action should take the type of the action (view or edit) into account when determining the availability of the action.

@tusmester tusmester added the bug label Jun 18, 2019

@gallayl

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

There is another scenario with PDF files. If you upload a PDF, the WopiOpenEdit and WopiOpenView will be available, and

  • when I try to open the file, the edit mode, GetWopiData fails (so this the scenario is similar)
  • when I try to open for read, I got the token from GetWopiData, but the Office Online displays the following error message:
    image

Is there a way to discover the capabilities of the Office Online server and allow WopiOpenEdit and WopiOpenView based on that?

@herflis herflis added this to the Sprint 188 milestone Jul 2, 2019

@herflis herflis modified the milestones: Sprint 188, Sprint 189 Jul 10, 2019

@herflis herflis modified the milestones: Sprint 189, Sprint 190 Jul 24, 2019

@herflis herflis closed this Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.