New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "sensio_framework_extra.router.annotations" disabled by default #576

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@Mediagone

Mediagone commented Jun 29, 2018

The config builder was not updated to match the new deprecations introduced in 5.2, then having sensio_framework_extra.router.annotations still defaulted to TRUE raises deprecation notices if no framework_extra.yaml file (with annotations disabled) is present in the project.

@cybernet

This comment has been minimized.

cybernet commented Jul 8, 2018

and this isn't merged ... because ?

@xabbuh

This comment has been minimized.

Member

xabbuh commented Jul 8, 2018

Changing the default value would be a BC break. But there is a pull request for the recipe (see symfony/recipes#430) to disable this option by default when the bundle is installed in a Flex application.

@fabpot

This comment has been minimized.

Member

fabpot commented Jul 23, 2018

Closing as we cannot change the default value.

@fabpot fabpot closed this Jul 23, 2018

@fabpot

This comment has been minimized.

Member

fabpot commented Jul 23, 2018

I've done the change directly in the Symfony Standard Edition: see symfony/symfony-standard#1133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment