Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire nyholm/psr7 as default factory for PSR-7 #608

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Contributor

nicolas-grekas commented Mar 11, 2019

No description provided.

@Nyholm

Nyholm approved these changes Mar 11, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:psr7 branch from 08b25f5 to 730db84 Mar 11, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:psr7 branch from 730db84 to f92f0e0 Mar 11, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:psr7 branch 7 times, most recently from d0b380b to 04a5802 Mar 11, 2019

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:psr7 branch from 04a5802 to d5ecd69 Mar 11, 2019

@nicolas-grekas

This comment has been minimized.

Copy link
Contributor Author

nicolas-grekas commented Mar 11, 2019

and green

@@ -5,7 +5,7 @@
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">

<services>
<service id="sensio_framework_extra.psr7.http_message_factory" class="Symfony\Bridge\PsrHttpMessage\Factory\DiactorosFactory" public="false" />
<service id="sensio_framework_extra.psr7.http_message_factory" class="Symfony\Bridge\PsrHttpMessage\Factory\PsrHttpFactory" public="false" autowire="true" />

This comment has been minimized.

@nicolas-grekas

nicolas-grekas Mar 11, 2019

Author Contributor

autowire="true", that's the trick to create decoupled configuration

javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Mar 12, 2019

minor #11135 Use nyholm/psr17 instead of deprecated Zend Diactoros (N…
…yholm)

This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #11135).

Discussion
----------

Use nyholm/psr17 instead of deprecated Zend Diactoros

The [DiactorosFactory](https://github.com/symfony/psr-http-message-bridge/blob/master/Factory/DiactorosFactory.php) is deprecated. We should update our docs to use a "pure" PSR-17 factory.

Related to: sensiolabs/SensioFrameworkExtraBundle#608

Commits
-------

dc361b9 Use nyholm/psr17 instead of deprecated Zend Diactoros
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.