Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix has_role compatibility in Symfony 3.4 #629

Merged
merged 1 commit into from Jul 8, 2019

Conversation

@ostrolucky
Copy link
Contributor

commented Jul 5, 2019

Fixes #628

Looked into tests too, but didn't see any simple way to write a test for 3.4 only, while avoiding deprecations

@xabbuh

xabbuh approved these changes Jul 5, 2019

@plozmun

This comment has been minimized.

Copy link

commented Jul 5, 2019

This also solve our 403 issues. Thank you @ostrolucky

@jtaylor100

This comment has been minimized.

Copy link

commented Jul 8, 2019

Ours too. Thank you @ostrolucky

@fabpot

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Thank you @ostrolucky.

@fabpot fabpot merged commit ec6f18e into sensiolabs:master Jul 8, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jul 8, 2019

bug #629 Fix has_role compatibility in Symfony 3.4 (ostrolucky)
This PR was merged into the 5.4.x-dev branch.

Discussion
----------

Fix has_role compatibility in Symfony 3.4

Fixes #628

Looked into tests too, but didn't see any simple way to write a test for 3.4 only, while avoiding deprecations

Commits
-------

ec6f18e Fix has_role compatibility in Symfony 3.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.