Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Expression Language installation suggestion #666

Closed
wants to merge 1 commit into from

Conversation

@nebkam
Copy link

nebkam commented Jan 9, 2020

In newer versions of Symfony (I've noticed it on 4.4 but it may appeared earlier), @Security annotation has a dependency on Expression Language Component.

In newer versions of Symfony (I've noticed it on 4.4 but it may appeared earlier), @Security annotation has a dependency on Expression Language Component.
@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 10, 2020

IIRC, the error message is explicit about installing it, right? If that's the case, there is no need to add it in the docs IMHO.

@nebkam

This comment has been minimized.

Copy link
Author

nebkam commented Jan 10, 2020

Yes, I agree the exception message is explicit:
To use the @Security tag, you need to use the Security component 2.4 or newer and install the ExpressionLanguage component.
The reason I've submitted this PR is because I thought it would make DX better to state the dependency upfront, without the need to run the code and fail, only to find out it was a hidden dependency.

@fabpot

This comment has been minimized.

Copy link
Member

fabpot commented Jan 10, 2020

It's not hidden, just optional. I still think that we do not need something in the docs. Shorter docs are always better.

@fabpot fabpot closed this Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.