New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX] Potential missing annotation route import #284

Closed
weaverryan opened this Issue Jul 4, 2014 · 2 comments

Comments

Projects
None yet
4 participants
@weaverryan
Contributor

weaverryan commented Jul 4, 2014

I believe there is a bug when using doctrine:generate:crud with the annotation format. Specifically, the routing import (to import the Controller directory with type: annotation) is not added. I believe you can see this here: https://github.com/sensiolabs/SensioGeneratorBundle/blob/master/Command/GenerateDoctrineCrudCommand.php#L122

My guess is that the thought is that if you originally generated the bundle with the annotation config format, then you'll already have this import. We should do a little more work to make sure that the controller is in fact being imported in routing. Without it, the CRUD seems to not work at first.

Thanks!

@benji07

This comment has been minimized.

Show comment
Hide comment
@HeahDude

This comment has been minimized.

Show comment
Hide comment
@HeahDude

HeahDude Nov 19, 2016

Member

I'm closing here since I've opened #527 to fix the controller generator command and the CRUD one was already fixed in #403. Thanks!

Member

HeahDude commented Nov 19, 2016

I'm closing here since I've opened #527 to fix the controller generator command and the CRUD one was already fixed in #403. Thanks!

@HeahDude HeahDude closed this Nov 19, 2016

fabpot added a commit that referenced this issue Jul 18, 2017

bug #527 Fixed Controller command not updating config routing file (H…
…eahDude)

This PR was merged into the 3.1.x-dev branch.

Discussion
----------

Fixed Controller command not updating config routing file

Closes #284.

Commits
-------

03cd84d Fixed Controller command not updating config routing file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment