[DX] Do not use parameters in generate:bundle service file #285

Closed
weaverryan opened this Issue Jul 5, 2014 · 3 comments

Comments

Projects
None yet
3 participants
@weaverryan
Contributor

weaverryan commented Jul 5, 2014

One easy win (imo) for the generate:bundle command is to generate a services.yml (or services.xml) file without using parameters.

Current:

parameters:
#    product.example.class: Acme\DemoBundle\Example

services:
#    product.example:
#        class: %product.example.class%
#        arguments: [@service_id, "plain_value", %parameter%]

Proposed:

services:
#    product.example:
#        class: Acme\DemoBundle\Example
#        arguments: [@service_id, "plain_value", %parameter%]

The parameters use for classes is only important if you're creating a reusable, third-party bundle. I hate explaining why this is done to new users, and that it doesn't actually apply to them (and they shouldn't do this).

Thanks!

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Jul 5, 2014

Member

👍

Member

fabpot commented Jul 5, 2014

👍

fabpot added a commit that referenced this issue Jul 7, 2014

feature #287 [DX] Do not use parameters in generate:bundle service fi…
…le (benji07)

This PR was merged into the 2.3.x-dev branch.

Discussion
----------

[DX] Do not use parameters in generate:bundle service file

Remove parameters generated by the generate:bundle command

Related to #285

Commits
-------

6529eee remove generated parameters in services.yml and services.xml
@xabbuh

This comment has been minimized.

Show comment
Hide comment
@xabbuh

xabbuh Aug 29, 2014

Member

@weaverryan Is this completely solved?

Member

xabbuh commented Aug 29, 2014

@weaverryan Is this completely solved?

@weaverryan

This comment has been minimized.

Show comment
Hide comment
@weaverryan

weaverryan Aug 29, 2014

Contributor

Yes! Thanks for the ping!

Contributor

weaverryan commented Aug 29, 2014

Yes! Thanks for the ping!

@weaverryan weaverryan closed this Aug 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment