Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate:bundle Allowing a namespace to be used without a vendor namespace #315

Merged
merged 1 commit into from Nov 29, 2014

Conversation

Projects
None yet
2 participants
@weaverryan
Copy link
Contributor

commented Nov 25, 2014

Hey guys!

This is a quick, BC version of #312, which has become a major update to the entire command. That's great, but it will break some BC and will need to be released as a new version.

But right now, it's still impossible to generate a bundle without a vendor namespace. That was the original issue, and the fix is very simple. This fixes that in a BC way. If you do omit the vendor namespace, it even gives you a warning (in case someone accidentally says Acme/FooBundle, which looks like AcmeFooBundle to the system).

I've tested both sides of the flow and it works fine. If someone else can double-check, that'll make Fabien's merge much easier. Screenshots Below!

Thanks!

screen shot 2014-11-25 at 5 16 28 pm
screen shot 2014-11-25 at 5 16 51 pm

@weaverryan weaverryan referenced this pull request Nov 25, 2014

Merged

Update generate:bundle for non-shared bundles and more #312

5 of 5 tasks complete
@fabpot

This comment has been minimized.

Copy link
Member

commented Nov 29, 2014

Thank you @weaverryan.

@fabpot fabpot merged commit 6fe3188 into sensiolabs:master Nov 29, 2014

2 checks passed

continuous-integration/travis-ci The Travis CI build passed
Details
default Success: Travis, fabbot
Details

fabpot added a commit that referenced this pull request Nov 29, 2014

bug #315 generate:bundle Allowing a namespace to be used without a ve…
…ndor namespace (weaverryan)

This PR was merged into the 2.4.x-dev branch.

Discussion
----------

generate:bundle Allowing a namespace to be used without a vendor namespace

Hey guys!

This is a quick, BC version of #312, which has become a major update to the entire command. That's great, but it will break some BC and will need to be released as a new version.

But right now, it's still impossible to generate a bundle without a vendor namespace. That was the original issue, and the fix is very simple. This fixes that in a BC way. If you *do* omit the vendor namespace, it even gives you a warning (in case someone accidentally says `Acme/FooBundle`, which looks like `AcmeFooBundle` to the system).

I've tested both sides of the flow and it works fine. If someone else can double-check, that'll make Fabien's merge much easier. Screenshots Below!

Thanks!

![screen shot 2014-11-25 at 5 16 28 pm](https://cloud.githubusercontent.com/assets/121003/5192677/59c114c2-74c7-11e4-9f0e-d4a36366598c.png)
![screen shot 2014-11-25 at 5 16 51 pm](https://cloud.githubusercontent.com/assets/121003/5192676/59c0e0e2-74c7-11e4-9e77-8ade8dc48ac1.png)

Commits
-------

6fe3188 Allowing a namespace to be used without a vendor namespace

@weaverryan weaverryan deleted the weaverryan:no-vendor-namespace branch Jan 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.