Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require ctype polyfill #164

Merged
merged 1 commit into from Jun 8, 2019

Conversation

Projects
None yet
4 participants
@BackEndTea
Copy link
Contributor

commented Jun 7, 2019

Fixes #163

@Nardberjean

This comment has been minimized.

Copy link

commented Jun 7, 2019

Thanks!

@Nardberjean

This comment has been minimized.

Copy link

commented Jun 7, 2019

I am not sure if adding or ext-ctype may help prevent conflits in some installation cases, where other packages may require ext-ctypes only and conflict with the polyfill.

@Nardberjean

This comment has been minimized.

Copy link

commented Jun 7, 2019

The polyfill is probably not loading when the extension is present and I see that symfony/skeleton and symfony/website-skeleton are replacing the polyfill so conflicts seems to be avoided.

@Nardberjean

This comment has been minimized.

Copy link

commented Jun 7, 2019

Looks like if adding the "or" would make it more readable for slow humans like me.

@fabpot

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

Thank you @BackEndTea.

@fabpot fabpot merged commit d114d9b into sensiolabs:master Jun 8, 2019

1 check passed

fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 8, 2019

minor #164 Require ctype polyfill (BackEndTea)
This PR was merged into the 6.0-dev branch.

Discussion
----------

Require ctype polyfill

Fixes #163

Commits
-------

d114d9b Require ctype polyfill
@BackEndTea

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2019

Thank you @fabpot & @nicolas-grekas

@BackEndTea BackEndTea deleted the BackEndTea:patch-2 branch Jun 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.