New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite check-disk to use sys-filesytem instead of df #2

Closed
mattyjones opened this Issue Jan 30, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@mattyjones
Member

mattyjones commented Jan 30, 2015

We should be using sys-filesystem instead of the output of df. If nothing more than this would just make it easier to test. The more generic Ruby code we can use the better.

It is my personal opinion here, but i have a strong aversion to anything that ties me to a specific architecture. If I can abstract out the code, even at the sake of moderate complexity, I think it is worth it.

@mattyjones mattyjones self-assigned this Jan 30, 2015

@mattyjones

This comment has been minimized.

Show comment
Hide comment
@mattyjones

mattyjones Feb 3, 2015

Member

This is functionally identical with the exception of include and ignore line patterns as we are now dealing with objects and strings. This is a very rough draft and will most likely be broken done and have common functionality put in lib/ but as a poc it works fine,

Member

mattyjones commented Feb 3, 2015

This is functionally identical with the exception of include and ignore line patterns as we are now dealing with objects and strings. This is a very rough draft and will most likely be broken done and have common functionality put in lib/ but as a poc it works fine,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment