Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement TLS connections, default to TLS connection #2
Pull Request Checklist
Is this in reference to an existing issue? No
Changes default plain text connection to TLS.
Known Compatablity Issues
(btw, there's a typo in the your header ;) )
It's 2016, we have Let's Encrypt. (and we're not deprecating plain text
Hi @GhostLyrics, thanks for the PR. I think that using TLS by default is reasonable from the perspective of preferring security, but I believe it means we will need to cut the next release with a major version change. Incrementing the major version in next release isn't a blocker, but it would be great to have some tests around the logic used in selecting TLS vs plain text connections.
My desire for tests aside, can you please rebase? I think updating changelog in #3 has introduced a conflict here.