New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPU utilisation, GPU memory usage and power draw to collected metrics #3

Merged
merged 3 commits into from Jan 31, 2017

Conversation

Projects
None yet
2 participants
@GhostLyrics
Contributor

GhostLyrics commented Jan 27, 2017

Pull Request Checklist

Is this in reference to an existing issue? No.

General

  • Update Changelog following the conventions laid out on Keep A Changelog

  • Update README with any necessary configuration snippets

  • Binstubs are created if needed

  • RuboCop passes

  • Existing tests pass

New Plugins

  • Tests

  • Add the plugin to the README

  • Does it have a complete header as outlined here

Purpose

Newer NVIDIA cards offer to read the Utilisation and Memory usage in percent, this PR adds that capability to the metrics.

Known Compatablity Issues

None; the check already looks for integers via Regex. If a metric is not available on an older card, nvidia-smi just returns N/A.

Additionally I want to apologize for the sloppy PR that was the first version of this. I wasn't aware the Github Mac GUI didn't respect PR templates.

@GhostLyrics

This comment has been minimized.

Show comment
Hide comment
@GhostLyrics

GhostLyrics Jan 31, 2017

Contributor

@sstarcher could you maybe review this one too, please and release a new version if it goes in?

Thank you.

Contributor

GhostLyrics commented Jan 31, 2017

@sstarcher could you maybe review this one too, please and release a new version if it goes in?

Thank you.

@sstarcher sstarcher merged commit b1b4371 into sensu-plugins:master Jan 31, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment