Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding asset doesn't update release drop down, readme or downloads section properly #72

Closed
rgeniesse opened this issue Jan 22, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@rgeniesse
Copy link

rgeniesse commented Jan 22, 2019

Expected behavior

Adding an asset shows readme, download links and all versions in releases drop down.

Current behavior

I've added a handler asset here:

https://bonsai.sensu.io/assets/rgeniesse/sensu-pushbullet-handler

But it seems to not want to update the releases drop down, the readme or add the download packages with their checksums to the lower right hand section. At somepoint something shook lose a bit as initially no releases were showing, now 0.0.4 and 0.0.5 are. Recompile releases seems to have no immediate effect or even in the following hours.

This should have 0.0.6 as well:

screen shot 2019-01-22 at 12 01 39 pm

screen shot 2019-01-22 at 12 03 01 pm

And the downloads section isn't populating properly:

screen shot 2019-01-22 at 12 01 43 pm

And then the readme you'll see is missing based on the asset link above.

Other assets that were added near or after mine appear to be working:

https://bonsai.sensu.io/assets/cwjohnston/sensu-pushover-handler
https://bonsai.sensu.io/assets/sensu/sensu-prometheus-collector

I've done a configuration comparison with .bonsai.yml to these other two repos and don't see any differences outside of single quoted values. Also done a few new releases after adding the asset to bonsai and that doesn't seem to do anything.

@mbiang mbiang added the bug Something isn't working label Jan 23, 2019
@mbiang
Copy link

mbiang commented Jan 25, 2019

We think this may be related to #73 and #69. Once this fixes are tested and merged we will try to reproduce this issue.

@rgeniesse
Copy link
Author

Thanks @mbiang. I thought I fixed that spacing error, but obviously did not (or it didn't end up in master somehow). I've updated it and re-ran the recompile releases action. The readme is now showing up. I don't know if that action will make the asset links appear, though. That may be a thing that happens on the CI side.

@rgeniesse
Copy link
Author

fwiw, the readme is working for the pushbullet handler after recompiling the release, but at some point after it disappears.

@mbiang
Copy link

mbiang commented Feb 12, 2019

@rgeniesse - this issue should now be resolved by #97. I'm going to close this. Please re-open if you encounter this issue again.

@mbiang mbiang closed this as completed Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants