Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add ability to have configuration changes reload sensu-enterprise instead issuing a restart #17

Closed
rgeniesse opened this issue Aug 15, 2019 · 0 comments · Fixed by #18

Comments

@rgeniesse
Copy link

Description of feature request

In Sensu Enterprise 2.6.0, a reload option was added to interactive with the service sensu-enterprise:

https://docs.sensu.io/sensu-enterprise/3.6/changelog/#enterprise-v2-6-0

IMPROVEMENT: Sensu Enterprise now loads configuration and validates it prior to reloading (SIGHUP). If configuration is determined to be invalid prior to reloading, Sensu will report invalid configuration definitions, and it will continue to run with its existing working configuration.

Currently, when a configuration change is detected in /etc/sensu/conf.d/ and Sensu Enterprise is being used, Puppet will attempt a restart on the senssu-enterprise service. If invalid JSON some how ends up inside /etc/sensu/conf.d/, this will cause the service to be stopped and then started again, putting sensu-enterprise into a non-running state.

This request is to have an option added for Puppet to execute a reload against sensu-enterprise instead of a restart on configuration changes, which allows for the above linked and quoted feature of the sensu-enterperirse service to be taken advantage of.

In looking at the code, a notify is being done to the service for configuration changes in /etc/sensu/conf.d, which based on Puppet documentation, results in a restart of the service.

https://github.com/sensu/sensu-puppet/blob/v2.63.0/manifests/check.pp#L271
https://github.com/sensu/sensu-puppet/blob/v2.63.0/manifests/write_json.pp#L60
https://puppet.com/docs/puppet/5.3/metaparameter.html#notify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant