sensuclassic_sorted_json

[bastelfreak]

Description of problem

• What did you do?

I use this module on a Puppetserver 6.5.0 environment

• What happened?

During an agent run, I get the following error message:

...
Info: Retrieving locales
Info: Loading facts
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Internal Server Error: org.jruby.exceptions.SecurityError: (SecurityError) Illegal method definition of method 'validate_keys' on line 8' in legacy function. See https://puppet.com/docs/puppet/latest/functions_refactor_legacy.html for more information
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

• What did you expect to happen?

I expected a function that doesn't use the legacy 3.x Puppet API.

• How can someone reproduce the problem?

I will try to post a minimale example later. Everything that uses the sensuclassic_sorted_json() method will produce this error.

Command used and debugging output

• What does your puppet config look like (including any hiera config)
• Is this a masterless or master based puppet setup?

Platform and version information

• Your OS: CentOS 6 for the Puppet agent, CentOS 7 for the Puppetserver.
• Your Ruby version: AIO versions. ruby 2.4.5p335 (2018-10-18 revision 65137) [x86_64-linux] on the agent, jruby 9.2.0.0 (2.5.0) 2018-05-24 81156a8 OpenJDK 64-Bit Server VM 25.222-b10 on 1.8.0_222-b10 +jit [linux-x86_64 on the server
• Your version of Puppet: puppet-agent-5.5.16-1.el6.x86_64 and puppetserver-6.5.0-1.el7.noarch
• Your version of Sensu: sensu-1.8.0-1.el6.x86_64
• Your version of this module: master branch

Anything else to add that you think will be helpful?

The metadata.json mentions that this module supports Puppet 6. The tests work, but the code clearly matches the described one in the error article at https://puppet.com/docs/puppet/latest/functions_refactor_legacy.html. I don't yet understand why the tests work.

[bastelfreak]

I did some debugging and noticed that we don't really use the master branch of this module but a strange patched version. I cleaned that up and tested it again with the last release 3.3.0 and master. The issue is fixed and doesn't reappear.