Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid monkey patching JSON module #25

Merged
merged 1 commit into from
Nov 2, 2019
Merged

Avoid monkey patching JSON module #25

merged 1 commit into from
Nov 2, 2019

Conversation

treydock
Copy link
Collaborator

Pull Request Checklist

Description

Avoid monkey patching the JSON module.

Related Issue

Fixes #24

@treydock treydock added the bug Something isn't working label Oct 30, 2019
@treydock treydock mentioned this pull request Oct 30, 2019
Closed
ghoneycutt
ghoneycutt approved these changes Oct 31, 2019
View reviewed changes
Copy link
Collaborator

@ghoneycutt ghoneycutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's see what Tim says.

@bastelfreak
Copy link

I did some tests and can confirm that this fixes the issue. Can you merge + release it?

@ghoneycutt ghoneycutt merged commit 41e5ee5 into master Nov 2, 2019
@ghoneycutt ghoneycutt deleted the json-function branch November 2, 2019 21:16
@ghoneycutt
Copy link
Collaborator

Thanks @bastelfreak

Released in v3.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghoneycutt ghoneycutt ghoneycutt approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

undefined method `pretty_generate' for Puppet::Pops::Loader::RubyFunctionInstantiator::JSON:Module
3 participants
@treydock @bastelfreak @ghoneycutt