(GH-29) Removes validate_bool() usage #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chadh This looks good but if you could please remove the changes to REFERENCES.md, CHANGELOG.md and metadata.json. Those chnages are made as part of the standard release process for this module so not necessary to update those in a pull request. |
|
for sure. couldn't tell from the CONTRIBUTING.md whether I was supposed to do it or not. |
|
@chadh Thanks for the contribution! |
chadh
force-pushed
the
remove_deprecated_function
branch
from
36021d1
to
45748b0
Compare
|
Hi Garrett! Need to make time to do a lot more. Okay, removed those other changes. |
ghoneycutt
approved these changes
Jun 3, 2020
|
Released in v3.5.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces
validate_bool()usage with Puppet TypesRelated Issue
Fixes #29 .
Motivation and Context
Per the issue, the
validate_bool()function is deprecated and produces a noisy warning in the puppetserver logs.How Has This Been Tested?
There is a unit test that covers the type checking. I updated the exception, but the tests still pass.
General
Update
README.mdwith any necessary configuration snippetsNew parameters are documented
New parameters have tests
Tests pass -
bundle exec rake validate lint spec