Fix dsc_service order issues #34
Conversation
There was a problem hiding this comment.
Tests carried out:
No client installed - Package was installed -> Config was put down -> DSC created the service and started it -> Sensu service refresh ran restarting it again
Client installed with wrong config and no service - Config was put down -> DSC created the service and started it -> Sensu service refresh ran restarting it again
Client installed with no config and no service - Config was put down -> DSC created the service and started it -> Sensu service refresh ran restarting it again
Hopefully tested the main scenarios but this change looks to work correctly putting config down before DSC starts the service. The service does get restarted again at the end of the puppet run due to the notify to the service but I do not see any way you can change that and is not a huge issue.
|
@treydock travis is failing. Perhaps a dependency needs pinned. |
|
Looks like we need a newer version of rspec-puppet. The issue: rodjek/rspec-puppet#796, the fix: rodjek/rspec-puppet#797, was in rspec-puppet 2.7.9 and we pin to 2.6.x , which won't ever see this necessary fix. I'll update the rspec-puppet dependency. |
|
I've pushed a fix. |
Pull Request Checklist
Description
Fix DSC service order of operations.
Related Issue
Fixes #32
Motivation and Context
It seems that
dsc_serviceis starting the service, notService['sensu-client']so this ensures that configs and other necessary items are in place before adding the DSC service.