Add Windows acceptance tests

[treydock]

Pull Request Checklist

Description

Add Windows acceptance tests
Support Windows 2016
Handle absence of os.architecture fact for Windows

Related Issue

Migrated from sensu/sensu-puppet#1052

[treydock]

Added appveyor to my namespace and it's failing because this module defaults to gem provider for sensu-plugin install and the rubygems version on appveyor is 3.0.2 which has no support for --no-ri and --no-rdoc that get executed by gem provider.

Defaulting all operating systems to sensuclassic_gem seems like the right move but is a breaking change as we'll be changing the default. For now I'm updating the acceptance tests to change the default.

[treydock]

Using sensuclassic_gem seems to end up using system Ruby and causes issues with appveyor tests using Ruby 2.5. Am trying to downgrade rubygems to 2.x in appveyor to avoid rubygems 3.x.

[ghoneycutt]

We don't want to change the code to support appveyor. Appveyor should allow us to run against the ruby versions we need.

[treydock]

We can but the pre-installed Ruby all have latest rubygems and latest rubygems breaks Puppet gem provider. This wasn't an issue a few months ago when I did first appveyor tests but I think that's because rubygems 3.x wasn't released that drops support for --no-ri and --no-rdoc. For now I'm just downgrading rubygems in appveyor installed Ruby. Looks like Puppet hasn't been updated to support latest rubygems: https://github.com/puppetlabs/puppet/blob/master/lib/puppet/provider/package/gem.rb#L131

[treydock]

Successful build: https://ci.appveyor.com/project/treydock/puppet-module-sensuclassic/builds/23267606

[ghoneycutt]

I think I've got appveyor turned on now. Can you try pushing to a new branch or something to trigger it?

[treydock]

Amended commit and forced push seems to have triggered appveyor.

[ghoneycutt]

@treydock could you please rebase this

[treydock]

Rebased

[ghoneycutt]

Released in v3.1.0 Thank you!