Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sensu/sensu-puppet
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.24.0
Choose a base ref
...
head repository: sensu/sensu-puppet
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.25.0
Choose a head ref
  • 4 commits
  • 4 files changed
  • 4 contributors

Commits on Jul 14, 2017

  1. Allow for undefined command param on ensure => absent 

    Before this change, declaring a sensu::check to be absent with no command would fail:

```
  sensu::check {
    'check_system_raid':
      ensure => 'absent';
  }
```
The above would cause:
```
Error: Could not retrieve catalog from remote server:
Error 400 on SERVER:
Evaluation Error:
Error while evaluating a Resource Statement, Sensu::Check[check_system_raid]:
expects a value for parameter 'command' at [..] on node [...]
```

This commit allows for undefined `command` parameter which would be validated only if ensure is present (default), raising a specific error if command is missing.

Conflicts:
	manifests/check.pp
    @kali-hernandez @Phil-Friderici
    kali-hernandez authored and Phil-Friderici committed Jul 14, 2017
    Configuration menu
    Copy the full SHA
    a0d11e2 View commit details
    Browse the repository at this point in the history

  2. (PR-528) Allow for undefined command param on ensure => absent 

    * Rebase against master
* Update docs
* Add tests for new functionality
    @Phil-Friderici
    Phil-Friderici committed Jul 14, 2017
    Configuration menu
    Copy the full SHA
    05a7679 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #745 from Phil-Friderici/PR-528 

    (PR-528) working with kali-hernandez
    @ghoneycutt
    ghoneycutt authored Jul 14, 2017
    Configuration menu
    Copy the full SHA
    2289fe2 View commit details
    Browse the repository at this point in the history

  4. Release v2.25.0 

    Allow sensu::check to be absent
    @ghoneycutt
    ghoneycutt committed Jul 14, 2017
    Configuration menu
    Copy the full SHA
    389ad7f View commit details
    Browse the repository at this point in the history
Loading