-
Notifications
You must be signed in to change notification settings - Fork 290
Comparing changes
Open a pull request
base repository: sensu/sensu-puppet
base: v2.27.0
head repository: sensu/sensu-puppet
compare: v2.28.0
- 17 commits
- 20 files changed
- 6 contributors
Commits on Jul 21, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 4d3b853 - Browse repository at this point
Copy the full SHA 4d3b853View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cf0984 - Browse repository at this point
Copy the full SHA 6cf0984View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ea481d - Browse repository at this point
Copy the full SHA 5ea481dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf0e8e5 - Browse repository at this point
Copy the full SHA bf0e8e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60947ec - Browse repository at this point
Copy the full SHA 60947ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for a4ed677 - Browse repository at this point
Copy the full SHA a4ed677View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f12bcc - Browse repository at this point
Copy the full SHA 2f12bccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 958ec82 - Browse repository at this point
Copy the full SHA 958ec82View commit details
Commits on Jul 24, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 636b3a8 - Browse repository at this point
Copy the full SHA 636b3a8View commit details
Commits on Jul 25, 2017
-
(#759) Add reference spec tests for sensu_check JSON provider
Without this patch there are no spec tests for the sensu_check JSON provider. This is problem because a reference is needed to specify the expected behavior of all providers. This patch implements a pattern of stubbing out the filesystem. All reads and writes in the provider itself are routed through the `read_file` and `write_json_object` methods. The RSpec tests then use rspec-mocks to stub out the reads and set expectations on the output. This reference may be applied to any provider using the `flush` method. The setter methods in the provider for each property are expected to update state in an instance variable, conventionally named @property_flush but named @conf in the sensu_check provider. The flush method is responsible for writing out @property_flush (@conf), which we intercept and set expectations on the data provided. N.B. There is a bug with Rspec where the expected and actual values of multi-line strings will not have a nice diff output if the two strings disagree on the presence of the trailing newline. See rspec/rspec-support#70 for more information. Because of this issue in combination with the use of IO#puts in the write_output class method, care should be taken with the examples to make sure the expected and actual values agree on the trailing newline. In this patch, the fixture data for the expected output is chomp()'ed to match the string passed to write_output(). Resolves #759
Configuration menu - View commit details
-
Copy full SHA for 6fb1efd - Browse repository at this point
Copy the full SHA 6fb1efdView commit details -
Merge pull request #741 from Phil-Friderici/GH-578
(GH-578) etc_dir should be configurable
Configuration menu - View commit details
-
Copy full SHA for 2c64888 - Browse repository at this point
Copy the full SHA 2c64888View commit details -
Merge pull request #765 from jeffmccune/759_provider_spec_tests
(#759) Add reference spec tests for sensu_check JSON provider
Configuration menu - View commit details
-
Copy full SHA for 2662f12 - Browse repository at this point
Copy the full SHA 2662f12View commit details -
Merge pull request #766 from alvagante/582
WIP 582 Don't do type convertion on keys of sensu_client_config custom param
Configuration menu - View commit details
-
Copy full SHA for d6ec173 - Browse repository at this point
Copy the full SHA d6ec173View commit details -
Merge pull request #753 from ITV/handle_silenced
Add handle_silenced parameter to handler defined type
Configuration menu - View commit details
-
Copy full SHA for 68946c0 - Browse repository at this point
Copy the full SHA 68946c0View commit details -
Add validation of spec/fixtures/unit/**/*.json
Validates that these files are JSON files.
Configuration menu - View commit details
-
Copy full SHA for f0ca4e3 - Browse repository at this point
Copy the full SHA f0ca4e3View commit details -
Merge pull request #768 from ghoneycutt/validate_json
Add validation of spec/fixtures/unit/**/*.json
Configuration menu - View commit details
-
Copy full SHA for 3ba3548 - Browse repository at this point
Copy the full SHA 3ba3548View commit details -
Configuration menu - View commit details
-
Copy full SHA for e39d2ac - Browse repository at this point
Copy the full SHA e39d2acView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.27.0...v2.28.0