Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sensu/sensu-puppet
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.27.0
Choose a base ref
...
head repository: sensu/sensu-puppet
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.28.0
Choose a head ref
  • 17 commits
  • 20 files changed
  • 6 contributors

Commits on Jul 21, 2017

  1. Configuration menu
    Copy the full SHA
    4d3b853 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6cf0984 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5ea481d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bf0e8e5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    60947ec View commit details
    Browse the repository at this point in the history
  6. explicitly test for false

    madAndroid committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    a4ed677 View commit details
    Browse the repository at this point in the history
  7. fix linting

    madAndroid committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    2f12bcc View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    958ec82 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2017

  1. Configuration menu
    Copy the full SHA
    636b3a8 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2017

  1. (#759) Add reference spec tests for sensu_check JSON provider

    Without this patch there are no spec tests for the sensu_check JSON provider.
    This is problem because a reference is needed to specify the expected behavior
    of all providers.
    
    This patch implements a pattern of stubbing out the filesystem.  All reads and
    writes in the provider itself are routed through the `read_file` and
    `write_json_object` methods.  The RSpec tests then use rspec-mocks to stub out
    the reads and set expectations on the output.
    
    This reference may be applied to any provider using the `flush` method.  The
    setter methods in the provider for each property are expected to update state in
    an instance variable, conventionally named @property_flush but named @conf in
    the sensu_check provider.  The flush method is responsible for writing out
    @property_flush (@conf), which we intercept and set expectations on the data
    provided.
    
    N.B. There is a bug with Rspec where the expected and actual values of
    multi-line strings will not have a nice diff output if the two strings disagree
    on the presence of the trailing newline.  See
    rspec/rspec-support#70 for more information.  Because
    of this issue in combination with the use of IO#puts in the write_output class
    method, care should be taken with the examples to make sure the expected and
    actual values agree on the trailing newline.  In this patch, the fixture data
    for the expected output is chomp()'ed to match the string passed to
    write_output().
    
    Resolves #759
    jeffmccune committed Jul 25, 2017
    Configuration menu
    Copy the full SHA
    6fb1efd View commit details
    Browse the repository at this point in the history
  2. Merge pull request #741 from Phil-Friderici/GH-578

    (GH-578) etc_dir should be configurable
    ghoneycutt authored Jul 25, 2017
    Configuration menu
    Copy the full SHA
    2c64888 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #765 from jeffmccune/759_provider_spec_tests

    (#759) Add reference spec tests for sensu_check JSON provider
    ghoneycutt authored Jul 25, 2017
    Configuration menu
    Copy the full SHA
    2662f12 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #766 from alvagante/582

    WIP 582  Don't do type convertion on keys of sensu_client_config custom param
    ghoneycutt authored Jul 25, 2017
    Configuration menu
    Copy the full SHA
    d6ec173 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #753 from ITV/handle_silenced

    Add handle_silenced parameter to handler defined type
    ghoneycutt authored Jul 25, 2017
    Configuration menu
    Copy the full SHA
    68946c0 View commit details
    Browse the repository at this point in the history
  6. Add validation of spec/fixtures/unit/**/*.json

    Validates that these files are JSON files.
    ghoneycutt committed Jul 25, 2017
    Configuration menu
    Copy the full SHA
    f0ca4e3 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #768 from ghoneycutt/validate_json

    Add validation of spec/fixtures/unit/**/*.json
    ghoneycutt authored Jul 25, 2017
    Configuration menu
    Copy the full SHA
    3ba3548 View commit details
    Browse the repository at this point in the history
  8. Release v2.28.0

    ghoneycutt committed Jul 25, 2017
    Configuration menu
    Copy the full SHA
    e39d2ac View commit details
    Browse the repository at this point in the history
Loading