Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sensu/sensu-puppet
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.35.0
Choose a base ref
...
head repository: sensu/sensu-puppet
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.36.0
Choose a head ref
  • 12 commits
  • 9 files changed
  • 6 contributors

Commits on Sep 7, 2017

  1. Configuration menu
    Copy the full SHA
    9f97793 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #813 from alvagante/769

    Added sensu_user and sensu_group params to sensu class #769
    ghoneycutt authored Sep 7, 2017
    Configuration menu
    Copy the full SHA
    1224fe6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cfe80ec View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2017

  1. Merge pull request #814 from Phil-Friderici/GH-745

    Add vagrant tests for add/remove checks with sensu::check
    ghoneycutt authored Sep 18, 2017
    Configuration menu
    Copy the full SHA
    0c0510b View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2017

  1. [815] Resolve circular dependency when using sensu::enterprise::dashb…

    …oard::api
    
    See issue #815 on Github for more details. Previously, when declaring the sensu
    class along with an instance of the sensu::enterprise::dashboard::api defined
    type, a circular dependency was raised by Puppet. This was caused because
    first, the sensu::enterprise::dashboard::api defined type declares an instance
    of the sensu_enterprise_dashboard_api_config type, and the
    sensu_enterprise_dashboard_api_config type contains, within the initialize
    method, an automatic "notify" on the "sensu-enterprise-dashboard" service (i.e.
    Service['sensu-enterprise-dashboard']). The sensu::enterprise::dashboard::api
    defined type also uses the require function on the sensu::enterprise::dashboard
    class, which sets a 'require' dependency on every resource within the class.
    Because Service['sensu-enterprise-dashboard'] is located within the
    sensu::enterprise::dashboard class, that means that
    Service['sensu-enterprise-dashboard'] contains a circular dependency on any
    instance of the sensu::enterprise::dashboard::api defined type.
    
    To resolve the circular dependency, this commit changes the require function
    within the sensu::enterprise::dashboard::api defined type to
    the include function which eliminates the 'require' dependency.
    
    I tested this change out with vagrant and was able to get JSON back from the
    API, but I'd prefer someone with greater Sensu Enterprise knowledge to validate
    and ensure that converting 'require' to 'include' didn't upset any existing
    dependencies.
    glarizza committed Sep 20, 2017
    Configuration menu
    Copy the full SHA
    2cebbde View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2017

  1. Merge pull request #816 from glarizza/815_circular_dependency

    [815] Resolve circular dependency when using sensu::enterprise::dashboard::api
    ghoneycutt authored Oct 20, 2017
    Configuration menu
    Copy the full SHA
    0476ca8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    82ae8e9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    99b1b48 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    85bf66e View commit details
    Browse the repository at this point in the history
  5. Merge pull request #829 from ghoneycutt/notify_enterprise_on_checks

    user on check for windows to use module defaults and notifying sensu-enterprise
    ghoneycutt authored Oct 20, 2017
    Configuration menu
    Copy the full SHA
    29b2a7b View commit details
    Browse the repository at this point in the history
  6. Merge pull request #830 from ghoneycutt/change_test_versions

    Change test versions
    ghoneycutt authored Oct 20, 2017
    Configuration menu
    Copy the full SHA
    732c48a View commit details
    Browse the repository at this point in the history
  7. Release v2.36.0

    ghoneycutt committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    d6fbaca View commit details
    Browse the repository at this point in the history
Loading