-
Notifications
You must be signed in to change notification settings - Fork 290
Comparing changes
Open a pull request
base repository: sensu/sensu-puppet
base: v2.35.0
head repository: sensu/sensu-puppet
compare: v2.36.0
- 12 commits
- 9 files changed
- 6 contributors
Commits on Sep 7, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 9f97793 - Browse repository at this point
Copy the full SHA 9f97793View commit details -
Merge pull request #813 from alvagante/769
Added sensu_user and sensu_group params to sensu class #769
Configuration menu - View commit details
-
Copy full SHA for 1224fe6 - Browse repository at this point
Copy the full SHA 1224fe6View commit details -
Configuration menu - View commit details
-
Copy full SHA for cfe80ec - Browse repository at this point
Copy the full SHA cfe80ecView commit details
Commits on Sep 18, 2017
-
Merge pull request #814 from Phil-Friderici/GH-745
Add vagrant tests for add/remove checks with sensu::check
Configuration menu - View commit details
-
Copy full SHA for 0c0510b - Browse repository at this point
Copy the full SHA 0c0510bView commit details
Commits on Sep 20, 2017
-
[815] Resolve circular dependency when using sensu::enterprise::dashb…
…oard::api See issue #815 on Github for more details. Previously, when declaring the sensu class along with an instance of the sensu::enterprise::dashboard::api defined type, a circular dependency was raised by Puppet. This was caused because first, the sensu::enterprise::dashboard::api defined type declares an instance of the sensu_enterprise_dashboard_api_config type, and the sensu_enterprise_dashboard_api_config type contains, within the initialize method, an automatic "notify" on the "sensu-enterprise-dashboard" service (i.e. Service['sensu-enterprise-dashboard']). The sensu::enterprise::dashboard::api defined type also uses the require function on the sensu::enterprise::dashboard class, which sets a 'require' dependency on every resource within the class. Because Service['sensu-enterprise-dashboard'] is located within the sensu::enterprise::dashboard class, that means that Service['sensu-enterprise-dashboard'] contains a circular dependency on any instance of the sensu::enterprise::dashboard::api defined type. To resolve the circular dependency, this commit changes the require function within the sensu::enterprise::dashboard::api defined type to the include function which eliminates the 'require' dependency. I tested this change out with vagrant and was able to get JSON back from the API, but I'd prefer someone with greater Sensu Enterprise knowledge to validate and ensure that converting 'require' to 'include' didn't upset any existing dependencies.
Configuration menu - View commit details
-
Copy full SHA for 2cebbde - Browse repository at this point
Copy the full SHA 2cebbdeView commit details
Commits on Oct 20, 2017
-
Merge pull request #816 from glarizza/815_circular_dependency
[815] Resolve circular dependency when using sensu::enterprise::dashboard::api
Configuration menu - View commit details
-
Copy full SHA for 0476ca8 - Browse repository at this point
Copy the full SHA 0476ca8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82ae8e9 - Browse repository at this point
Copy the full SHA 82ae8e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99b1b48 - Browse repository at this point
Copy the full SHA 99b1b48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85bf66e - Browse repository at this point
Copy the full SHA 85bf66eView commit details -
Merge pull request #829 from ghoneycutt/notify_enterprise_on_checks
user on check for windows to use module defaults and notifying sensu-enterprise
Configuration menu - View commit details
-
Copy full SHA for 29b2a7b - Browse repository at this point
Copy the full SHA 29b2a7bView commit details -
Merge pull request #830 from ghoneycutt/change_test_versions
Change test versions
Configuration menu - View commit details
-
Copy full SHA for 732c48a - Browse repository at this point
Copy the full SHA 732c48aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d6fbaca - Browse repository at this point
Copy the full SHA d6fbacaView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.35.0...v2.36.0