Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sensu/sensu-puppet
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.4.0
Choose a base ref
...
head repository: sensu/sensu-puppet
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.5.0
Choose a head ref
  • 12 commits
  • 45 files changed
  • 2 contributors

Commits on Jun 27, 2017

  1. Use supported versions of modules in fixtures for spec tests

    @ghoneycutt
    ghoneycutt committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    682b27e View commit details
    Browse the repository at this point in the history

  2. Use newer puppetlabs_spec_helper which requires puppet-lint v2 

    metadata_lint and some syntax checks are now handled by
puppetlabs_spec_helper
    @ghoneycutt
    ghoneycutt committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    4cb1690 View commit details
    Browse the repository at this point in the history

  3. Adjust spec tests for defined types to explicitly include sensu class 

    These defined types uses private variables from the sensu class, which
must be included in the catalog.
    @ghoneycutt
    ghoneycutt committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    f885445 View commit details
    Browse the repository at this point in the history

  4. Add default facts to spec_helper for spec tests

    @ghoneycutt
    ghoneycutt committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    7cb76f3 View commit details
    Browse the repository at this point in the history

  5. Fix spec test by ensuring facts are set appropriately for Windows

    @ghoneycutt
    ghoneycutt committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    32dd882 View commit details
    Browse the repository at this point in the history

  6. Comply with style using puppet-lint v2 

    The bulk of the changes deal with using fully qualified paths to
variables. For example $sensu::user is now $::sensu::user.
    @ghoneycutt
    ghoneycutt committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    a2814c4 View commit details
    Browse the repository at this point in the history

  7. Add community style checks 

    https://github.com/camptocamp/puppet-lint-alias-check
https://github.com/fiddyspence/puppetlint-variablecase

We already comply with the style, so no changes to the code.
    @ghoneycutt
    ghoneycutt committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    faeb928 View commit details
    Browse the repository at this point in the history

  8. Use puppetlabs-apt >= 4.0.0 

    Uses the latest major version which ensures compatibility with some
older versions of Puppet v4.
    @ghoneycutt
    ghoneycutt committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    7179c92 View commit details
    Browse the repository at this point in the history

  9. Merge pull request #686 from ghoneycutt/679_upgrade_puppetlabs_spec_h… 

    …elper_and_puppet_lint

(GH-679) Upgrade puppetlabs_spec_helper and puppet-lint
    @ghoneycutt
    ghoneycutt authored Jun 27, 2017
    Configuration menu
    Copy the full SHA
    a6fe87c View commit details
    Browse the repository at this point in the history

  10. (GH-680) Add file validation checks for Vagrantfile and shell scripts… 

    … (*.sh)
    @ghoneycutt
    ghoneycutt committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    69234e3 View commit details
    Browse the repository at this point in the history

  11. Merge pull request #687 from ghoneycutt/680_file_validation 

    (GH-680) Add file validation checks for Vagrantfile and shell scripts (*.sh)
    @ghoneycutt
    ghoneycutt authored Jun 27, 2017
    Configuration menu
    Copy the full SHA
    efc901e View commit details
    Browse the repository at this point in the history

  12. Release v2.5.0 

    Require puppetlabs/apt >= 4.0.0
Use newest puppetlabs_spec_helper
Use puppet-lint v2 and comply with style
    @ghoneycutt
    ghoneycutt committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    679829e View commit details
    Browse the repository at this point in the history
Loading