New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sensu::client::config keepalives 'change' every run #336
Comments
What version of the module are you using? |
1.5.0 |
Any joy with this? Also, when's the next release of the module out? I'm looking forward to being able to incorporate the fixes from #298 in my environments. |
@poolski Can you supply the manifest that is causing these messages? I'll try to reproduce. |
I will, @superseb |
With the addition of the
I'm running v1.5.5 of the module to test if it fixes anything. |
@poolski That's quite weird, you are using v1.5.5 at the moment? Did you restart the puppetmaster? (puppetmaster/pupperserver/pe-httpd) |
@superseb yeah I did. It was throwing all sorts of crazy invalid setting errors till I tried that. Also, yes, I'm using v1.5.5. |
Ok, what Puppet version? Are you using multiple environments? |
Oh @poolski , please post your manifest aswell so I can try to reproduce |
We are running
And yes, we have multiple envs, managed with r10k. I'm testing it on our "develop" env before rolling it out to the wider world. |
Hi, I'm using sensu-puppet v1.5.5 now, but it've been occured before this version. (sorry I can't tell exactly from which version) Here is part of my manifest class { '::sensu':
version => '0.17.1-1',
rabbitmq_ssl_cert_chain => '/etc/sensu/ssl/cert.pem',
rabbitmq_ssl_private_key => '/etc/sensu/ssl/key.pem',
rabbitmq_host => $server_host,
rabbitmq_port => 5671,
rabbitmq_password => $rabbitmq_pass,
rabbitmq_vhost => '/sensu',
purge_config => false,
server => $server,
api => $server,
subscriptions => $subscriptions,
client_custom => {
'keepalive' => {
'handlers' => ['default', 'slack']
}
},
use_embedded_ruby => $embedded_ruby,
sensu_plugin_version => latest,
} I've specified 'client_port' and 'redis_reconnect_on_error' explicitly, but it didn't fix. |
Okay. So:
class { '::sensu':
version => '0.17.1-1',
rabbitmq_ssl_cert_chain => '/etc/sensu/ssl/cert.pem',
rabbitmq_ssl_private_key => '/etc/sensu/ssl/key.pem',
rabbitmq_host => $server_host,
rabbitmq_port => 5671,
rabbitmq_password => $rabbitmq_pass,
rabbitmq_vhost => '/sensu',
purge_config => false,
server => $server,
api => $server,
subscriptions => $subscriptions,
client_keepalive => {
'handlers' => ['default', 'slack']
}
},
use_embedded_ruby => $embedded_ruby,
sensu_plugin_version => latest,
} Let me know if this solves it for you. |
@superseb |
Okay cool, @poolski if you could post your manifest I can take a look. |
@superseb, alright, here we go. It's a bit broken up because most of the stuff lives in Hiera and is loaded automatically by class-based params. My r10k Sensu block is applied to all hosts (it's in a 'base' profile) and looks like this:
The corresponding data is as follows. Checks have been removed because there are lots of them and they aren't complaining. {
"sensu::client": true,
"sensu::client_custom": {
"handlers": [
"default"
],
"keepalive": {
"high_flap_threshold": "20",
"low_flap_threshold": "5",
"refresh": 14400,
"thresholds": {
"critical": 120,
"warning": 90
}
}
},
"sensu::plugins": [
"puppet:///modules/sensu_site/plugins/system/check-apt.sh",
"puppet:///modules/sensu_site/plugins/system/check-cpu.rb",
"puppet:///modules/sensu_site/plugins/system/check-disk.rb",
"puppet:///modules/sensu_site/plugins/system/check-load.rb",
"puppet:///modules/sensu_site/plugins/system/cpu-metrics.rb",
"puppet:///modules/sensu_site/plugins/processes/check-procs.rb",
"puppet:///modules/sensu_site/plugins/system/check-ram.rb",
"puppet:///modules/sensu_site/plugins/sendmail/sendmail-mqueue.rb",
"puppet:///modules/sensu_site/plugins/enabler/check-pidfile.sh",
"puppet:///modules/sensu_site/plugins/network/check-ports.sh"
],
"sensu::purge_config": true,
"sensu::rabbitmq_host": "10.10.10.10",
"sensu::rabbitmq_password": "passwordz",
"sensu::rabbitmq_port": 5671,
"sensu::rabbitmq_ssl": true,
"sensu::rabbitmq_ssl_cert_chain": "puppet:///modules/sensu_site/ssl/cert.pem",
"sensu::rabbitmq_ssl_private_key": "puppet:///modules/sensu_site/ssl/key.pem",
"sensu::rabbitmq_vhost": "/sensu",
"sensu::rabbitmq_reconnect_on_error": true,
"sensu::redis_reconnect_on_error": true,
"sensu::sensu_plugin_version": "present",
"sensu::subscriptions": [
"common"
],
"sensu::use_embedded_ruby": true,
} |
Additionally, having installed
|
I'll take a look today, did you restart the master after getting |
I did indeed. I killed Apache and waited for the passenger processes to stop before restarting, too. |
In a clean Vagrant setup with open source Puppet 3.7.5-1 master+agent and the following declaration, it doesn't reset the properties in every run. Could you verify @poolski ? The issue you are experiencing seems like the old bug with custom providers and environments, but should be fixed in 3.7.5 (same version as I tested it on) class { '::sensu':
client => true,
client_custom => {
'handlers' => [
'default'
],
},
client_keepalive => {
"high_flap_threshold" => "20",
"low_flap_threshold" => "5",
"refresh" => 14400,
"thresholds" => {
"critical" => 120,
"warning" => 90
}
},
purge_config => true,
rabbitmq_host => '10.10.10.10',
rabbitmq_password => 'password',
rabbitmq_port => 5671,
rabbitmq_ssl => true,
rabbitmq_vhost => '/sensu',
rabbitmq_reconnect_on_error => true,
redis_reconnect_on_error => true,
subscriptions => [ 'common' ],
use_embedded_ruby => true,
} |
@poolski Any update on this? |
Hi, 1st run: 2nd run: The manifest: $load_warn=inline_template("<%= sprintf('%.2f',(@processorcount.to_i*1.25)) %>,<%= sprintf('%.2f',(@processorcount.to_i*1)) %>,<%= sprintf('%.2f',(@processorcount.to_i*0.8)) %>")
$load_crit=inline_template("<%= sprintf('%.2f',($processorcount.to_i*1.66)) %>,<%= sprintf('%.2f',($processorcount.to_i*1.25)) %>,<%= sprintf('%.2f',($processorcount.to_i*1)) %>")
class { 'sensu':
rabbitmq_ssl_private_key => "puppet:///data/sensu/certs/client_key.pem",
rabbitmq_ssl_cert_chain => "puppet:///data/sensu/certs/client_cert.pem",
rabbitmq_password => 'xxx',
rabbitmq_host => 'my-sensu-server',
rabbitmq_port => 5671,
rabbitmq_vhost => "/sensu",
plugins => [
'puppet:///data/sensu/plugins/system/check-ntp.rb',
'puppet:///data/sensu/plugins/system/check-disk.rb',
'puppet:///data/sensu/plugins/system/check-load.rb',
],
use_embedded_ruby => true,
sensu_plugin_provider => sensu_gem,
sensu_plugin_version => 'present',
install_repo => false,
client_custom => {
check_load => {
warning => $load_warn,
critical => $load_crit,
},
},
subscriptions => ['base']
}
if $is_virtual == "false" {
sensu::subscription { 'physical': }
} |
@superseb, since you were the main contact for this issue, would it be possible to look at my last comment and maybe point me where my problem could be? Thanks. |
@superseb I'm now running v1.5.5 which as I understand it has both #343 and #345 rolled in? Still experiencing the same issue and something new: Restarting the puppetmaster fixes it but for only one run after which it reverts back to erroring. |
@poolski No, v1.5.5 doesn't contain those fixes. Let me ping @jamtur01 or @jlambert121 to release a new version. |
Oh, durp! Thanks @superseb. |
@superseb - so another fun fact. I'm testing out using
Now it "adds" the repo key every time Puppet runs. Also, even though the port changes have been fixed, it's still resetting keepalives and flap thresholds, even though nothing's changed |
@poolski Did you split your data to client_custom and client_keepalive? I'll see if I can reproduce your apt::key. |
@superseb - here's my data: "sensu::client_custom": {
"handlers": [
"default"
],
"keepalive": {
"high_flap_threshold": "20",
"low_flap_threshold": "5",
"refresh": 14400,
"thresholds": {
"critical": 120,
"warning": 90
}
}
} |
@poolski Please see example like I posted before, and let me know if this helps. class { '::sensu':
client => true,
client_custom => {
'handlers' => [
'default'
],
},
client_keepalive => {
"high_flap_threshold" => "20",
"low_flap_threshold" => "5",
"refresh" => 14400,
"thresholds" => {
"critical" => 120,
"warning" => 90
}
},
purge_config => true,
rabbitmq_host => '10.10.10.10',
rabbitmq_password => 'password',
rabbitmq_port => 5671,
rabbitmq_ssl => true,
rabbitmq_vhost => '/sensu',
rabbitmq_reconnect_on_error => true,
redis_reconnect_on_error => true,
subscriptions => [ 'common' ],
use_embedded_ruby => true,
} |
That's just what I was about to do @superseb :D |
@poolski 👍 😄 |
@superseb when I first started using the module, I don't recall there being a dedicated keepalive field - it had to be shoehorned in with client_custom. |
Okay, progress - now all I have is it trying to change the port on me... The above happen with no discernible pattern. |
Awesome. This was fixed in #342, what codebase are you running on now? |
v1.5.5 |
Yeah, the fix was merged after the v1.5.5 tag. |
Alright, I'll try master and see what happens |
Can someone suggest to me how to fix "Invalid parameter reconnect_on_error on Sensu_rabbitmq_config"? using master, client ver 3.7.5, puppetserver 1.0.2, r10k environments. restarted both puppetservers - which fixes the issue for the first run, then back to invalid parameter errors. |
Looks like the invalid parameter issue is related to r10k environments. If you want the change to stick you need to update this module in all environments simultaneously and restart the puppetserver. |
@superseb any idea when the next version will be released? |
@poolski I can't release a new version, let's ping @jamtur01 @jlambert121 again. Does it work as expected now? |
This is one issue that I think needs to get closed out before a release. Is this still an issue with the latest master? |
I believe master as of a week or so ago fixed the issue for me. It'd be On Tue, Jun 30, 2015, 9:31 AM Justin Lambert notifications@github.com
|
I had the same issue with the port changing on every run. Switched from 1.5.5 to master and now it's fixed. |
I'm going to close this, let us know if this is still an issue. |
@jlambert121 I'm getting the following error if I switch to using
What broke between 1.5.5 and master? :( |
Restarted? #377 seems to contain a fix for source param issues. |
Yeah I restarted All The Things. According to #377, it's been merged into master and fixes that error, but something's still not right. |
Ok, so, stopping the puppetserver actually seemed to fix it. Issuing an Might be worth noting in docs somewhere? |
Just chiming in here, any ideas when this will get rolled into an official release? |
@devshorts I keep hoping to get a 2.0 release done real soon. Enterprise support looks like it's pretty much done. |
Every single time I run puppet, the module seems to change my thresholds for keepalive, flapping detection etc as follows. It's not a big deal but it does add time to puppet runs and it's a bit misleading, given no change takes place
The text was updated successfully, but these errors were encountered: