Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensu_redis_config changes on every run #357

Closed
tizzo opened this issue May 27, 2015 · 5 comments
Closed

Sensu_redis_config changes on every run #357

tizzo opened this issue May 27, 2015 · 5 comments

Comments

@tizzo
Copy link

tizzo commented May 27, 2015

I have an issue where both Sensu_redis_config and Sensu_client_config claim to change on every run despite the fact that the configuration doesn't actually seem to be changing.

Haven't started debugging yet but thought I'd open an issue for others encountering the same.

@warmfusion
Copy link

I've observed the same with keepalive config...
in my case:

Step 1 - Added a custom hash with tip = 'a string'
Step 2 - move tip to the common configuration (ie removed custom hash)

Symtoms are then:

Jun  4 15:34:25 srv puppet-agent[5617]: (/Stage[main]/Sensu::Client::Config/Sensu_client_config[srv.priv.example.com]/keepalive) keepalive changed 'custom => {"tip"=>"This box lives on physical1"}, handlers => ["default", "slack-high"], subdue => {"begin"=>"7PM UTC", "end"=>"7AM UTC"}, thresholds => {"warning"=>60, "critical"=>300}, tip => This box lives on physical1' to 'handlers => ["default", "slack-high"], subdue => {"begin"=>"7PM UTC", "end"=>"7AM UTC"}, thresholds => {"warning"=>60, "critical"=>300}, tip => This box lives on physical1'

But the configuration file does not change.

Manually removing the file, and running puppet replaces the file properly.

@warmfusion
Copy link

Readded a hash for custom and the constant changes went away.

@jlambert121
Copy link
Contributor

I believe this is the issue that puppet < 4 doesn't have a true nil/undefined. This should resolved in puppet 4 with puppet improvements.

@jlambert121
Copy link
Contributor

@tizzo are you still having this issue on master? There have been some provider fixes that hopefully have taken care of your issue.

@warmfusion removing attributes in puppet < 4 will have that issue - you have to manually go in and either remove the config from your generated files or just remove the generated files and let puppet remake them.

@jlambert121
Copy link
Contributor

If you guys still have issues with this, please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants